Skip to content

Commit c088ea9

Browse files
committed
Specify kernel in the rake file, and a basic test of deny list
1 parent a40fca8 commit c088ea9

2 files changed

Lines changed: 12 additions & 9 deletions

File tree

lib/tasks/geo_combine.rake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ namespace :geocombine do
3131
ogm_repos.reject! { |repo| denylist.include?(repo) }
3232
end
3333
ogm_repos.each do |repo|
34-
system "echo #{repo} && mkdir -p #{ogm_path} && cd #{ogm_path} && git clone --depth 1 #{repo}"
34+
Kernel.system "echo #{repo} && mkdir -p #{ogm_path} && cd #{ogm_path} && git clone --depth 1 #{repo}"
3535
end
3636
end
3737

@@ -45,7 +45,7 @@ namespace :geocombine do
4545
paths.each do |path|
4646
next unless File.directory?(path)
4747

48-
system "echo #{path} && cd #{path} && git pull origin"
48+
Kernel.system "echo #{path} && cd #{path} && git pull origin"
4949
end
5050
end
5151

spec/lib/tasks/geo_combine_spec.rb

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
require 'spec_helper'
44
require 'rake'
55

6-
describe 'geocombine rake tasks' do
7-
describe 'geocombine:clone' do
8-
it 'does not clone repos on deny list' do
9-
allow(Kernel).to receive(:system)
10-
Rake::Task['geocombine:clone'].invoke
11-
expect(Kernel).to have_received(:system).exactly(20).times
12-
end
6+
describe 'geo_combine.rake' do
7+
before do
8+
load('lib/tasks/geo_combine.rake')
9+
end
10+
describe 'geocombine:clone' do
11+
it 'does not clone repos on deny list' do
12+
allow(Kernel).to receive(:system)
13+
Rake::Task['geocombine:clone'].invoke
14+
expect(Kernel).to have_received(:system).exactly(20).times
1315
end
16+
end
1417
end

0 commit comments

Comments
 (0)