Revert to dist build type#99
Merged
Merged
Conversation
The dist-custom-elements build doesn't let us bundle everything into a single script the way we want (consumers would still have to use importmaps, and things get weird). The dist build works correctly, but due to a bug (stenciljs/core#4231), we can't build the deck.gl-based COG viewer. This disables the deck.gl viewer for now so that the package can build.
thatbudakguy
force-pushed
the
revert-dist-type
branch
from
9611c0c to
4dbaa9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dist-custom-elements build doesn't let us bundle everything
into a single script the way we want (consumers would still have
to use importmaps, and things get weird).
The dist build works correctly, but due to a bug
(stenciljs/core#4231), we can't build
the deck.gl-based COG viewer.
This disables the deck.gl viewer for now so that the package can
build.