Resolve ESLint prefer-const

Author: brianhelba

web/eslint.config.ts

@@ -19,7 +19,6 @@ export default defineConfigWithVueTs(
       '@typescript-eslint/no-explicit-any': 'off',
       // Temporary ignores until rules can be fixed
       'vue/require-v-for-key': 'off',
-      'prefer-const': 'off',
       'vue/valid-v-for': 'off',
       'vue/return-in-computed-property': 'off',
       'vue/no-ref-as-operand': 'off',

web/src/components/map/MapTooltip.vue

@@ -74,7 +74,8 @@ const rasterValue = computed(() => {
       const data = mapStore.rasterTooltipDataCache[raster.id]?.data;
       if (data) {
         const { lng, lat } = clickedFeature.value.pos;
-        let { xmin, xmax, ymin, ymax, srs } = raster.metadata.bounds;
+        const { srs } = raster.metadata.bounds;
+        let { xmin, xmax, ymin, ymax } = raster.metadata.bounds;
         [xmin, ymin] = proj4(srs, "EPSG:4326", [xmin, ymin]);
         [xmax, ymax] = proj4(srs, "EPSG:4326", [xmax, ymax]);
         // Convert lat/lng to array indices

web/src/components/projects/DatasetUpload.vue

@@ -130,10 +130,10 @@ function submit() {
         }
         const layerOptions = await Promise.all(
             layers.value.map(async (l) => {
-                let fileValues = await Promise.all(
+                const fileValues = await Promise.all(
                     l.files.map(async (f) => await uploadFile(f))
                 )
-                let fileItems = await Promise.all(
+                const fileItems = await Promise.all(
                     l.files.map(async (f, i) => await createFileItem({
                         name: f.name,
                         file: fileValues[i],

web/src/components/sidebars/FloatingPanel.vue

@@ -27,7 +27,7 @@ function getPanelContainerClass() {
 }
 
 function getPanelContainerStyle() {
-  let styleObj: Record<string, string> = {};
+  const styleObj: Record<string, string> = {};
   styleObj.order = panel.value?.order.toString() || '0';
   if (!panel.value?.position) {
     if (panel.value?.height && !panel.value.collapsed) {
@@ -39,7 +39,7 @@ function getPanelContainerStyle() {
 }
 
 function getPanelStyle() {
-  let styleObj: Record<string, string> = {};
+  const styleObj: Record<string, string> = {};
   if (panel.value?.position) {
     styleObj["z-index"] = "2"; // above vuetify navigation drawer
     styleObj.visibility = "visible"; // prevent hiding when sidebar closes

web/src/components/sidebars/LayerStyle.vue

@@ -45,8 +45,8 @@ const colormaps = computed(() => styleStore.colormaps);
 
 const projectPermission = computed(() => {
     if (!projectStore.currentProject || !appStore.currentUser) return 'none'
-    let user = appStore.currentUser
-    let proj = projectStore.currentProject
+    const user = appStore.currentUser
+    const proj = projectStore.currentProject
     let perm = 'follower'
     if (proj.owner?.id === user.id || user.is_superuser ) {
         perm = "owner";

web/src/components/sidebars/LegendPanel.vue

@@ -26,12 +26,12 @@ function getColormapPreviews(layer: Layer) {
     )
     const vector = currentFrame?.vector
     return currentStyleSpec.colors.map((colorConfig) => {
-        let name = colorConfig.name
+        const name = colorConfig.name
         let discrete = false;
         let nColors = 1;
         let colorBy = undefined;
         let range: [number | undefined, number | undefined] = [undefined, undefined];
-        let useFeatureProps = vector && colorConfig.use_feature_props;
+        const useFeatureProps = vector && colorConfig.use_feature_props;
         let valueColors = undefined
         let colormap = styleStore.colormaps.find((cmap) => cmap.id === colorConfig.colormap?.id)
         if (colormap) {

web/src/components/sidebars/NodeAnimation.vue

@@ -67,7 +67,7 @@ function rewind() {
 
 watch(currentTick, async () => {
   if (nodeChanges.value) {
-    let deactivated = nodeChanges.value[currentTick.value];
+    const deactivated = nodeChanges.value[currentTick.value];
     if (props.network) networkStore.setNetworkDeactivatedNodes(props.network, deactivated || [], true);
     if (props.additionalAnimationLayers) {
       props.additionalAnimationLayers.forEach((layer) => {

web/src/store/map.ts

@@ -313,7 +313,7 @@ export const useMapStore = defineStore('map', () => {
 
     // Must collect all source Ids so they can be removed after all layers
     // have been removed, since multple layers may use the same source
-    let sourceIdsToRemove = new Set<string>();
+    const sourceIdsToRemove = new Set<string>();
     const updatedLayerIds: string[] = [];
     layerIds.forEach((id) => {
       // Rasters have implicit bounds layers that also need to be removed
@@ -519,7 +519,8 @@ export const useMapStore = defineStore('map', () => {
 
     const bounds = raster.metadata.bounds;
     const boundsSourceId = sourceId.replace('raster', 'bounds');
-    let { xmin, xmax, ymin, ymax, srs } = bounds;
+    const { srs } = bounds;
+    let { xmin, xmax, ymin, ymax } = bounds;
     [xmin, ymin] = proj4(srs, "EPSG:4326", [xmin, ymin]);
     [xmax, ymax] = proj4(srs, "EPSG:4326", [xmax, ymax]);
     map.addSource(boundsSourceId, {

web/src/store/network.ts

@@ -175,7 +175,7 @@ export const useNetworkStore = defineStore('network', () => {
     async function isNodeActive(nodeId: number, dataset: Dataset) {
         const network = await getNetwork(nodeId, dataset);
         if (network) {
-            let deactivated = Array.from(networkStates.value[network.id]?.deactivated?.nodes || []);
+            const deactivated = Array.from(networkStates.value[network.id]?.deactivated?.nodes || []);
             return !deactivated.includes(nodeId)
         }
     }

web/src/store/style.ts

@@ -271,7 +271,7 @@ function getVectorSizePaintProperty(styleSpec: StyleSpec, groupName: string, pro
 }
 
 function getVectorVisibilityPaintProperty(styleSpec: StyleSpec, groupName: string) {
-    let filters: any[] = []
+    const filters: any[] = []
     const colorSpec = styleSpec.colors.find((c) => [groupName, 'all'].includes(c.name))
     if (colorSpec && !colorSpec.visible) {
         return 0