Conversation
Since 2021-09 it has become the unofficial standard to send pinch events on touchpads as wheel events with the ctrl key held down. This should correspond to zoom. GeoJS actions predate this and had used ctrl+wheel as rotate (and wheel by itself as zoom). This changes it so shift+wheel is rotate, and wheel+(no shift) regardless of ctrl state is zoom.
Contributor
Author
|
See https://developer.mozilla.org/en-US/docs/Web/API/WheelEvent for when this was adopted by different browsers |
|
🎉 This PR is included in version 1.14.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 2021-09 it has become the unofficial standard to send pinch events on touchpads as wheel events with the ctrl key held down. This should correspond to zoom. GeoJS actions predate this and had used ctrl+wheel as rotate (and wheel by itself as zoom). This changes it so shift+wheel is rotate, and wheel+(no shift) regardless of ctrl state is zoom.