fix: Update a style from an array could fail#1378
Closed
Conversation
When updating a style from a buffer taking into account that there are multiple vertices per pixel, the fallback lookup could be wrong. The initial update worked, but subsequent updates could fail.
manthey
force-pushed
the
update-style-from-array
branch
from
e3c6385 to
473b873
Compare
Contributor
Author
|
This was unneeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating a style from a buffer taking into account that there are multiple vertices per pixel, the fallback lookup could be wrong. The initial update worked, but subsequent updates could fail.