Merged
Conversation
Contributor
Author
|
@annehaley This change helps, but at high zoom levels with a lot of points we are still needlessly recomputing some things. |
In a test of 1.3M points, this saves 500-700 ms per zoom transition in one test. The clustering took a maximum of 94ms for the zoom transition; the remaining time is in the webGL point transformation and property fetches. The next improvement would be to cache those values per zoom level.
manthey
force-pushed
the
speed-up-cluster-transition
branch
from
07fd746 to
5c5b020
Compare
|
🎉 This PR is included in version 1.14.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a test of 1.3M points, this saves 500-700 ms per zoom transition in one test. The clustering took a maximum of 94ms for the zoom transition; the remaining time is in the webGL point transformation and property fetches. The next improvement would be to cache those values per zoom level.