Skip to content

Commit 00e88a1

Browse files
Universal mac builds
1 parent afd552c commit 00e88a1

1 file changed

Lines changed: 15 additions & 10 deletions

File tree

.github/workflows/build.yml

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,21 @@ jobs:
4949
# security unlock-keychain -p "" ~/Library/Keychains/login.keychain-db
5050
# security find-identity -v -p codesigning
5151

52-
- name: "Building electron app"
52+
- name: "Building electron app for mac"
53+
if: ${{ startsWith(matrix.os, 'macos') }}
5354
env:
5455
OSX_SIGN: 1
5556
APPLE_SIGNING_IDENTITY: ${{ secrets.APPLE_SIGNING_IDENTITY }}
5657
APPLE_ID: ${{ secrets.APPLE_ID }}
5758
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
5859
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
60+
run: npm run make -- --arch=universal --platform=darwin
61+
62+
- name: "Building electron app for windows"
63+
if: ${{ startsWith(matrix.os, 'windows') }}
64+
env:
5965
run: npm run make
6066

61-
6267
- name: Locate zip file
6368
id: find_zip
6469
run: |
@@ -112,15 +117,15 @@ jobs:
112117
# - name: Re-zip macos
113118
# run: |
114119
# ditto -c -k --keepParent release-assets/macos/*/*.app ./meshery-macos.zip
115-
- name: Re-zip macos
116-
run: |
117-
cd release-assets/macos
118-
zip -r ../meshery-macos-$VERSION.zip .
120+
# - name: Re-zip macos
121+
# run: |
122+
# cd release-assets/macos
123+
# zip -r ../meshery-macos-$VERSION.zip .
119124

120-
- name: Re-zip windows
121-
run: |
122-
cd release-assets/windows
123-
zip -r ../meshery-windows-$VERSION.zip .
125+
# - name: Re-zip windows
126+
# run: |
127+
# cd release-assets/windows
128+
# zip -r ../meshery-windows-$VERSION.zip .
124129

125130
- name: Create release
126131
uses: softprops/action-gh-release@v2

0 commit comments

Comments
 (0)