From ea3325c45e71095b3880b14dcb486381e96cc205 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 25 May 2026 11:02:24 +0000 Subject: [PATCH 1/2] types(acp): add missing parameter type annotations Add type annotations to parameters that were missing types in the ACP module: - test_utils.py: Add IO[bytes] type annotation for stdout parameter in UnbufferedJsonRpcReader.__init__() - token_streamer.py: Add Any type annotation for tool_call parameter in _handle_tool_call_streaming() (uses dynamic attribute access) Addresses item from code quality report. Closes #751 Co-authored-by: openhands --- openhands_cli/acp_impl/events/token_streamer.py | 3 ++- openhands_cli/acp_impl/test_utils.py | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/openhands_cli/acp_impl/events/token_streamer.py b/openhands_cli/acp_impl/events/token_streamer.py index 87c1d518..574abdc5 100644 --- a/openhands_cli/acp_impl/events/token_streamer.py +++ b/openhands_cli/acp_impl/events/token_streamer.py @@ -11,6 +11,7 @@ from __future__ import annotations import asyncio +from typing import Any from acp import ( Client, @@ -238,7 +239,7 @@ async def _send() -> None: else: self.loop.run_until_complete(_send()) - def _handle_tool_call_streaming(self, tool_call) -> None: + def _handle_tool_call_streaming(self, tool_call: Any) -> None: if not tool_call: return diff --git a/openhands_cli/acp_impl/test_utils.py b/openhands_cli/acp_impl/test_utils.py index 35d85d6b..231c5819 100644 --- a/openhands_cli/acp_impl/test_utils.py +++ b/openhands_cli/acp_impl/test_utils.py @@ -21,7 +21,7 @@ import select import subprocess import time -from typing import Any +from typing import IO, Any class UnbufferedJsonRpcReader: @@ -31,7 +31,7 @@ class UnbufferedJsonRpcReader: that can cause messages to get stuck in buffers. """ - def __init__(self, stdout) -> None: + def __init__(self, stdout: IO[bytes]) -> None: self.stdout = stdout self.buffer = b"" self.fd = stdout.fileno() From 50ceb98a87d75f204d8c8aef3a99f4ad980e6c8e Mon Sep 17 00:00:00 2001 From: enyst Date: Mon, 25 May 2026 12:57:44 +0000 Subject: [PATCH 2/2] chore: retrigger CI for PR #754 Co-authored-by: openhands