Skip to content

types(acp): add missing parameter type annotations #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enyst merged 2 commits into from
May 25, 2026
Merged

types(acp): add missing parameter type annotations #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea3325c
types(acp): add missing parameter type annotations
github-actions[bot] May 25, 2026
50ceb98
chore: retrigger CI for PR #754
enyst May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openhands_cli/acp_impl/events/token_streamer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from __future__ import annotations

import asyncio
from typing import Any

from acp import (
Client,
Expand Down Expand Up @@ -238,7 +239,7 @@ async def _send() -> None:
else:
self.loop.run_until_complete(_send())

def _handle_tool_call_streaming(self, tool_call) -> None:
def _handle_tool_call_streaming(self, tool_call: Any) -> None:
if not tool_call:
return

Expand Down
4 changes: 2 additions & 2 deletions openhands_cli/acp_impl/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import select
import subprocess
import time
from typing import Any
from typing import IO, Any


class UnbufferedJsonRpcReader:
Expand All @@ -31,7 +31,7 @@ class UnbufferedJsonRpcReader:
that can cause messages to get stuck in buffers.
"""

def __init__(self, stdout) -> None:
def __init__(self, stdout: IO[bytes]) -> None:
self.stdout = stdout
self.buffer = b""
self.fd = stdout.fileno()
Expand Down
Loading