fix(acp): add TypedDicts for JSON-RPC messages in test_utils.py#783
Open
github-actions[bot] wants to merge 1 commit into
Open
fix(acp): add TypedDicts for JSON-RPC messages in test_utils.py#783github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Introduces typed JSON-RPC 2.0 message structures for better type safety in ACP testing utilities. TypedDicts added: - JsonRpcError: Error object with code, message, data - JsonRpcRequest: Request with jsonrpc, method, params, id - JsonRpcResponse: Response with jsonrpc, id, result, error Also: - Added class-level type annotations to UnbufferedJsonRpcReader - Updated function signatures to use the new types Closes #780 Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces typed JSON-RPC 2.0 message structures for better type safety in ACP testing utilities.
Changes
New TypedDicts
JsonRpcError: Error object withcode,message,datafieldsJsonRpcRequest: Request message withjsonrpc,method,params,idfieldsJsonRpcResponse: Response message withjsonrpc,id,result,errorfieldsAdditional Improvements
UnbufferedJsonRpcReadersend_jsonrpc_and_wait()validate_jsonrpc_response()test_jsonrpc_messages()Related Issue
Addresses findings from #780
Testing
make lint)make test)This PR was automatically generated by the Code Quality Report workflow.