Skip to content

Upstream merge+timeslider subclass#433

Merged
erictheise merged 15 commits into
stagingfrom
upstream-merge+timeslider-subclass
Jul 2, 2026
Merged

Upstream merge+timeslider subclass#433
erictheise merged 15 commits into
stagingfrom
upstream-merge+timeslider-subclass

Conversation

@erictheise

Copy link
Copy Markdown
Member

Rebases and incorporates #327. Includes other fixes to reduce the number of test failures and errors (OpenHistoricalMap/issues#1180) (OpenHistoricalMap/issues#1390) (OpenHistoricalMap/issues#1391).

erictheise and others added 15 commits June 17, 2026 16:52
…which has the "Legend/Map Key" necessary for the overlay test
…which has the "Legend/Map Key" necessary for the overlay test
Restored normal page loading to be synchronous. Load the time slider synchronously as part of page loading. Fixed a bad merge in directions.js. Removed inconsistent support for date parameters as query parameters, leaving only support for date parameters as hash parameters.

Resolved conflicts in:
	app/assets/javascripts/index/directions.js
	app/assets/javascripts/index/export.js
	app/assets/javascripts/index/new_note.js
@erictheise erictheise merged commit 5828e67 into staging Jul 2, 2026
2 of 10 checks passed
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
1 Warning
⚠️ Merge commits are found in PR. Please rebase to get rid of the merge commits in this PR, see CONTRIBUTING.md.

Generated by 🚫 Danger

@erictheise erictheise moved this from In Production to Ready for Staging in OpenHistoricalMap Dev Planning Jul 2, 2026
@erictheise erictheise moved this from Ready for Staging to On Staging in OpenHistoricalMap Dev Planning Jul 2, 2026
@erictheise erictheise deleted the upstream-merge+timeslider-subclass branch July 2, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: On Staging

Development

Successfully merging this pull request may close these issues.

2 participants