refactor: Improve error handling and fix typo

rainxchzed · rainxchzed · commit 61e33a98a0ed · 2026-02-13T21:37:08.000+05:00
This commit improves error handling for `RateLimitException` across several features and corrects a typo.

- **refactor(error)**: Implemented consistent error handling for `RateLimitException`.
  - The Apps, Search, Details, and Developer Profile screens now display a specific error message to the user when a GitHub API rate limit is exceeded.
- **fix(starred)**: Corrected a typo in the `StarredRepos` feature, renaming `OnSingInClick` to `OnSignInClick` for consistency.
- **chore(di)**: Removed a large block of commented-out Koin module definitions from `SharedModules.kt` to clean up the codebase.
diff --git a/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/app/di/SharedModules.kt b/composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/app/di/SharedModules.kt
@@ -18,191 +18,4 @@ val mainModule: Module = module {
             authenticationState = get()
         )
     }
-}
-
-//val authModule: Module = module {
-//    // Repository
-//    single<AuthenticationRepository> {
-//        AuthenticationRepositoryImpl(tokenDataSource = get())
-//    }
-//
-//    // ViewModel
-//    viewModel {
-//        AuthenticationViewModel(
-//            authenticationRepository = get(),
-//            browserHelper = get(),
-//            clipboardHelper = get(),
-//            scope = get()
-//        )
-//    }
-//}
-
-//val homeModule: Module = module {
-//    // Repository
-//    single<HomeRepository> {
-//        HomeRepositoryImpl(
-//            githubNetworkClient = get(),
-//            platform = get(),
-//            appStateManager = get(),
-//            cachedDataSource = get()
-//        )
-//    }
-//
-//    single<CachedTrendingDataSource> {
-//        CachedTrendingDataSource(
-//            platform = get()
-//        )
-//    }
-//
-//    // ViewModel
-//    viewModel {
-//        HomeViewModel(
-//            homeRepository = get(),
-//            installedAppsRepository = get(),
-//            platform = get(),
-//            syncInstalledAppsUseCase = get(),
-//            favouritesRepository = get(),
-//            starredRepository = get()
-//        )
-//    }
-//}
-//
-//val searchModule: Module = module {
-//    // Repository
-//    single<SearchRepository> {
-//        SearchRepositoryImpl(
-//            githubNetworkClient = get(),
-//            appStateManager = get()
-//        )
-//    }
-//
-//
-//    // ViewModel
-//    viewModel {
-//        SearchViewModel(
-//            searchRepository = get(),
-//            installedAppsRepository = get(),
-//            syncInstalledAppsUseCase = get(),
-//            favouritesRepository = get(),
-//            starredRepository = get()
-//        )
-//    }
-//}
-//val favouritesModule: Module = module {
-//    // ViewModel
-//    viewModel {
-//        FavouritesViewModel(
-//            favouritesRepository = get()
-//        )
-//    }
-//}
-//
-//val detailsModule: Module = module {
-//    // Repository
-//    single<DetailsRepository> {
-//        DetailsRepositoryImpl(
-//            github = get(),
-//            appStateManager = get(),
-//            localizationManager = get()
-//        )
-//    }
-//
-//    // ViewModel
-//    viewModel { params ->
-//        DetailsViewModel(
-//            repositoryId = params.get(),
-//            detailsRepository = get(),
-//            downloader = get<Downloader>(),
-//            installer = get<Installer>(),
-//            platform = get(),
-//            helper = get(),
-//            installedAppsRepository = get(),
-//            favouritesRepository = get(),
-//            packageMonitor = get<zed.rainxch.core.data.services.PackageMonitor>(),
-//            syncInstalledAppsUseCase = get(),
-//            starredRepository = get()
-//        )
-//    }
-//}
-//val repoAuthorModule: Module = module {
-//    // Repository
-//    single<DeveloperProfileRepository> {
-//        DeveloperProfileRepositoryImpl(
-//            httpClient = get(),
-//            platform = get(),
-//            installedAppsDao = get(),
-//            favouritesRepository = get()
-//        )
-//    }
-//
-//    // ViewModel
-//    viewModel { params ->
-//        DeveloperProfileViewModel(
-//            repository = get(),
-//            favouritesRepository = get(),
-//            username = params.get(),
-//        )
-//    }
-//}
-//
-//val settingsModule: Module = module {
-//    // Repository
-//    single<SettingsRepository> {
-//        SettingsRepositoryImpl(
-//            tokenDataSource = get()
-//        )
-//    }
-//
-//    // ViewModel
-//    viewModel {
-//        SettingsViewModel(
-//            browserHelper = get(),
-//            themesRepository = get(),
-//            settingsRepository = get()
-//        )
-//    }
-//}
-//val starredReposModule: Module = module {
-//    // Repository
-//    single<StarredRepository> {
-//        _root_ide_package_.zed.rainxch.core.data.repository.StarredRepositoryImpl(
-//            httpClient = get(),
-//            starredRepoDao = get(),
-//            installedAppsDao = get(),
-//            platform = get()
-//        )
-//    }
-//
-//    // ViewModel
-//    viewModel {
-//        StarredReposViewModel(
-//            starredRepository = get(),
-//            favouritesRepository = get(),
-//            tokenDataSource = get()
-//        )
-//    }
-//}
-//
-//val appsModule: Module = module {
-//    // Repository
-//    single<AppsRepository> {
-//        AppsRepositoryImpl(
-//            appLauncher = get(),
-//            appsRepository = get()
-//        )
-//    }
-//
-//    // ViewModel
-//    viewModel {
-//        AppsViewModel(
-//            appsRepository = get(),
-//            installedAppsRepository = get(),
-//            installer = get(),
-//            downloader = get(),
-//            packageMonitor = get(),
-//            detailsRepository = get(),
-//            platform = get(),
-//            syncInstalledAppsUseCase = get()
-//        )
-//    }
-//}
+}
diff --git a/feature/apps/presentation/src/commonMain/kotlin/zed/rainxch/apps/presentation/AppsViewModel.kt b/feature/apps/presentation/src/commonMain/kotlin/zed/rainxch/apps/presentation/AppsViewModel.kt
@@ -290,9 +290,12 @@ class AppsViewModel(
                 cleanupUpdate(app.packageName, app.latestAssetName)
                 updateAppState(app.packageName, UpdateState.Idle)
                 throw e
-            } catch (e: RateLimitException) {
+            } catch (_: RateLimitException) {
                 logger.debug("Rate limited during update for ${app.packageName}")
                 updateAppState(app.packageName, UpdateState.Idle)
+                _events.send(
+                    AppsEvent.ShowError(getString(Res.string.rate_limit_exceeded))
+                )
             } catch (e: Exception) {
                 logger.error("Update failed for ${app.packageName}: ${e.message}")
                 cleanupUpdate(app.packageName, app.latestAssetName)
diff --git a/feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsViewModel.kt b/feature/details/presentation/src/commonMain/kotlin/zed/rainxch/details/presentation/DetailsViewModel.kt
@@ -255,7 +255,7 @@ class DetailsViewModel(
                 logger.error("Rate limited: ${e.message}")
                 _state.value = _state.value.copy(
                     isLoading = false,
-                    errorMessage = null
+                    errorMessage = getString(Res.string.rate_limit_exceeded)
                 )
             } catch (t: Throwable) {
                 logger.error("Details load failed: ${t.message}")
diff --git a/feature/dev-profile/presentation/src/commonMain/kotlin/zed/rainxch/devprofile/presentation/DeveloperProfileViewModel.kt b/feature/dev-profile/presentation/src/commonMain/kotlin/zed/rainxch/devprofile/presentation/DeveloperProfileViewModel.kt
@@ -113,7 +113,7 @@ class DeveloperProfileViewModel(
                     it.copy(
                         isLoading = false,
                         isLoadingRepos = false,
-                        errorMessage = e.message ?: "Unexpected error"
+                        errorMessage = e.message
                     )
                 }
 
diff --git a/feature/search/presentation/src/commonMain/kotlin/zed/rainxch/search/presentation/SearchViewModel.kt b/feature/search/presentation/src/commonMain/kotlin/zed/rainxch/search/presentation/SearchViewModel.kt
@@ -227,7 +227,15 @@ class SearchViewModel(
                     it.copy(isLoading = false, isLoadingMore = false)
                 }
             } catch (e: RateLimitException) {
-                logger.debug("Rate limit exceed: ${e.message}")
+                logger.debug("Rate limit exceeded: ${e.message}")
+                _state.update {
+                    it.copy(
+                        isLoading = false,
+                        isLoadingMore = false,
+                        errorMessage = e.message
+                    )
+                }
+
             } catch (e: CancellationException) {
                 logger.debug("Search cancelled (expected): ${e.message}")
             } catch (e: Exception) {
diff --git a/feature/starred/presentation/src/commonMain/kotlin/zed/rainxch/starred/presentation/StarredReposAction.kt b/feature/starred/presentation/src/commonMain/kotlin/zed/rainxch/starred/presentation/StarredReposAction.kt
@@ -6,7 +6,7 @@ sealed interface StarredReposAction {
     data object OnNavigateBackClick : StarredReposAction
     data object OnRefresh : StarredReposAction
     data object OnRetrySync : StarredReposAction
-    data object OnSingInClick : StarredReposAction
+    data object OnSignInClick : StarredReposAction
     data object OnDismissError : StarredReposAction
     data class OnRepositoryClick(val repository: StarredRepositoryUi) : StarredReposAction
     data class OnDeveloperProfileClick(val username: String) : StarredReposAction
diff --git a/feature/starred/presentation/src/commonMain/kotlin/zed/rainxch/starred/presentation/StarredReposRoot.kt b/feature/starred/presentation/src/commonMain/kotlin/zed/rainxch/starred/presentation/StarredReposRoot.kt
@@ -70,7 +70,7 @@ fun StarredReposRoot(
                 StarredReposAction.OnNavigateBackClick -> onNavigateBack()
                 is StarredReposAction.OnRepositoryClick -> onNavigateToDetails(action.repository.repoId)
                 is StarredReposAction.OnDeveloperProfileClick -> onNavigateToDeveloperProfile(action.username)
-                StarredReposAction.OnSingInClick -> onNavigateToAuthentication()
+                StarredReposAction.OnSignInClick -> onNavigateToAuthentication()
                 else -> viewModel.onAction(action)
             }
         }
@@ -108,7 +108,7 @@ fun StarredScreen(
                         icon = Icons.Default.Star,
                         actionText = stringResource(Res.string.sign_in_with_github),
                         onActionClick = {
-                            onAction(StarredReposAction.OnSingInClick)
+                            onAction(StarredReposAction.OnSignInClick)
                         },
                         modifier = Modifier.align(Alignment.Center)
                     )
diff --git a/feature/starred/presentation/src/commonMain/kotlin/zed/rainxch/starred/presentation/StarredReposViewModel.kt b/feature/starred/presentation/src/commonMain/kotlin/zed/rainxch/starred/presentation/StarredReposViewModel.kt
@@ -136,7 +136,7 @@ class StarredReposViewModel (
                 // Handled in composable
             }
 
-            is StarredReposAction.OnSingInClick -> {
+            is StarredReposAction.OnSignInClick -> {
                 // Handled in composable
             }
 

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ class DetailsViewModel(`
`255`	`255`	`logger.error("Rate limited: ${e.message}")`
`256`	`256`	`_state.value = _state.value.copy(`
`257`	`257`	`isLoading = false,`
`258`		`- errorMessage = null`
	`258`	`+ errorMessage = getString(Res.string.rate_limit_exceeded)`
`259`	`259`	`)`
`260`	`260`	`} catch (t: Throwable) {`
`261`	`261`	`logger.error("Details load failed: ${t.message}")`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ class DeveloperProfileViewModel(`
`113`	`113`	`it.copy(`
`114`	`114`	`isLoading = false,`
`115`	`115`	`isLoadingRepos = false,`
`116`		`- errorMessage = e.message ?: "Unexpected error"`
	`116`	`+ errorMessage = e.message`
`117`	`117`	`)`
`118`	`118`	`}`
`119`	`119`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ fun StarredReposRoot(`
`70`	`70`	`StarredReposAction.OnNavigateBackClick -> onNavigateBack()`
`71`	`71`	`is StarredReposAction.OnRepositoryClick -> onNavigateToDetails(action.repository.repoId)`
`72`	`72`	`is StarredReposAction.OnDeveloperProfileClick -> onNavigateToDeveloperProfile(action.username)`
`73`		`- StarredReposAction.OnSingInClick -> onNavigateToAuthentication()`
	`73`	`+ StarredReposAction.OnSignInClick -> onNavigateToAuthentication()`
`74`	`74`	`else -> viewModel.onAction(action)`
`75`	`75`	`}`
`76`	`76`	`}`
`@@ -108,7 +108,7 @@ fun StarredScreen(`
`108`	`108`	`icon = Icons.Default.Star,`
`109`	`109`	`actionText = stringResource(Res.string.sign_in_with_github),`
`110`	`110`	`onActionClick = {`
`111`		`- onAction(StarredReposAction.OnSingInClick)`
	`111`	`+ onAction(StarredReposAction.OnSignInClick)`
`112`	`112`	`},`
`113`	`113`	`modifier = Modifier.align(Alignment.Center)`
`114`	`114`	`)`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ class StarredReposViewModel (`
`136`	`136`	`// Handled in composable`
`137`	`137`	`}`
`138`	`138`
`139`		`- is StarredReposAction.OnSingInClick -> {`
	`139`	`+ is StarredReposAction.OnSignInClick -> {`
`140`	`140`	`// Handled in composable`
`141`	`141`	`}`
`142`	`142`