Fix HI3536CV100 chip generation detect

Author: dimerr

src/hal/hisi/hal_hisi.c

@@ -719,21 +719,6 @@ static const char *get_chip_V3(uint8_t scsysid0) {
     }
 }
 
-static const char *get_chip_NVR3516(uint8_t scsysid0) {
-    switch (scsysid0) {
-    case 0:
-    case 1:
-        return "3521DV100";
-    case 2:
-        return "3536CV100";
-    case 3:
-        return "3520DV400";
-    default:
-        fprintf(stderr, "reserved value %#x", scsysid0);
-        return "unknown";
-    }
-}
-
 static const char *get_hisi_chip_id(uint32_t family_id, uint8_t scsysid0) {
     switch (family_id) {
     case 0x3516A100:
@@ -800,7 +785,19 @@ static const char *get_hisi_chip_id(uint32_t family_id, uint8_t scsysid0) {
     case 0x3559A100:
         return "3559AV100";
     case 0xBDA9D100:
-        return get_chip_NVR3516(scsysid0);
+        switch (scsysid0) {
+            case 0:
+            case 1:
+                return "3521DV100";
+            case 2:
+                chip_generation = HISI_3536C;
+                return "3536CV100";
+            case 3:
+                return "3520DV400";
+            default:
+                fprintf(stderr, "reserved value %#x", scsysid0);
+                return "unknown";
+        }
     case 0x72050200:
         // former 3516EV200
         chip_generation = HISI_V4;