Skip to content

Commit d74090e

Browse files
widgetiiclaude
andauthored
ci(release): make the Telegram binary notification non-blocking (#174)
The ipctool-release run on master went red even though every build target compiled and both assets uploaded. The only hard failure was the "Send binary to Telegram" step: its `curl --max-time 15` to api.telegram.org timed out (exit 28), and unlike the surrounding `Build sources` / `Create release` steps it had no `continue-on-error`, so a flaky notification gated the whole release. A notification is advisory; it must not fail a release whose build succeeded and whose assets already uploaded. Add `continue-on-error: true` to that step (matching the existing treatment of the build and create-release steps). Note: the "Create release" step still logs a non-fatal `already_exists / tag_name` annotation because all matrix targets race to create the same `latest` tag; it is already `continue-on-error: true`, so it does not fail the run. Left as-is here. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent e7a0098 commit d74090e

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,10 @@ jobs:
155155

156156
- name: Send binary to Telegram
157157
if: steps.build.outcome == 'success'
158+
# A notification timing out (curl exit 28 against api.telegram.org)
159+
# must never fail a release whose build succeeded and whose assets
160+
# already uploaded — keep it advisory.
161+
continue-on-error: true
158162
env:
159163
TG_TOKEN: ${{ secrets.TELEGRAM_TOKEN_BOT_OPENIPC }}
160164
TG_CHANNEL: ${{ secrets.TELEGRAM_CHANNEL_OPENIPC_DEV }}

0 commit comments

Comments
 (0)