Skip to content

Fix intermittent GenerationIdTest.testMultiRS by re-advertising genId on change #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vharseko merged 2 commits into from
Jul 11, 2026
Merged

Fix intermittent GenerationIdTest.testMultiRS by re-advertising genId on change #725

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc3bbed
Fix intermittent GenerationIdTest.testMultiRS by re-advertising genId…
vharseko Jul 10, 2026
17d2ae1
Apply review suggestion: shorter comment, re-advertise only valid gen…
vharseko Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...er-legacy/src/main/java/org/opends/server/replication/server/ReplicationServerDomain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*
* Copyright 2006-2010 Sun Microsystems, Inc.
* Portions Copyright 2011-2016 ForgeRock AS.
* Portions Copyrighted 2026 3A Systems, LLC.
*/
package org.opends.server.replication.server;

Expand Down Expand Up @@ -1722,6 +1723,14 @@ public long changeGenerationId(long generationId)

this.generationId = generationId;
this.generationIdSavedStatus = false;

// generationId gossip is purely event-driven: it only travels in the
// topology messages sent on connect/disconnect/status events. Re-advertise
// on every real transition so a peer that missed one converges on the next.
if (generationId > 0)
{
sendTopoInfoToAll();
}
}
return oldGenerationId;
}
Expand Down
Loading