Replace Nashorn with Rhino as JavaScript engine fallback (#85)

Author: maximthomas

.github/workflows/build.yml

@@ -2,7 +2,7 @@ name: Build
 
 on:
   push:
-    branches: [ 'sustaining/1.8.x','master' ]
+    branches: [ 'sustaining/1.8.x','master', 'issues/**', 'features/**' ]
   pull_request:
 jobs:
   build-maven:

OpenICF-java-framework/connector-framework-internal/pom.xml

@@ -21,6 +21,8 @@
  with the fields enclosed by brackets [] replaced by
  your own identifying information:
  "Portions Copyrighted [year] [name of copyright owner]"
+
+ Portions Copyrighted 2024-2026 3A Systems LLC.
 -->
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
     <modelVersion>4.0.0</modelVersion>
@@ -36,22 +38,6 @@
         The IdentityConnectors framework provides a container to separate the Connector bundle from the application.
         The framework provides many common features that developers would otherwise need to implement on their own.
     </description>
-    <profiles>
-        <profile>
-            <id>jdk17.options</id>
-            <activation>
-                <jdk>[17,)</jdk>
-            </activation>
-            <dependencies>
-                <dependency>
-                    <groupId>org.openjdk.nashorn</groupId>
-                    <artifactId>nashorn-core</artifactId>
-                    <version>15.4</version>
-                    <optional>true</optional>
-                </dependency>
-            </dependencies>
-        </profile>
-    </profiles>
 
     <dependencies>
         <dependency>
@@ -76,6 +62,14 @@
             <!-- @see: org/identityconnectors/framework/impl/test/TestHelpersImpl.java -->
         </dependency>
 
+        <!--Optional dependencies-->
+        <dependency>
+            <groupId>org.apache.servicemix.bundles</groupId>
+            <artifactId>org.apache.servicemix.bundles.rhino</artifactId>
+            <version>1.7.15_1</version>
+            <optional>true</optional>
+        </dependency>
+
         <!-- Test Dependencies -->
         <dependency>
             <groupId>org.testng</groupId>

OpenICF-java-framework/connector-framework-internal/src/main/java/org/identityconnectors/common/script/javascript/JavaScriptExecutorFactory.java

@@ -20,6 +20,8 @@
  * with the fields enclosed by brackets [] replaced by
  * your own identifying information:
  * "Portions Copyrighted [year] [name of copyright owner]"
+ *
+ * Portions Copyrighted 2024-2026 3A Systems LLC.
  */
 
 package org.identityconnectors.common.script.javascript;
@@ -55,6 +57,10 @@ public class JavaScriptExecutorFactory extends ScriptExecutorFactory {
      */
     public JavaScriptExecutorFactory() {
         ScriptEngine engine = manager.getEngineByName(JAVA_SCRIPT);
+        if(engine == null) {
+            manager.registerEngineName(JAVA_SCRIPT, new org.mozilla.javascript.engine.RhinoScriptEngineFactory());
+            engine = manager.getEngineByName(JAVA_SCRIPT);
+        }
         if (null == engine) {
             throw new IllegalStateException("JavaScript Engine is not found");
         }