Skip to content

Commit 3beb3e8

Browse files
Copilotvharseko
andauthored
fix: remove hardcoded OPENIDM_PASSWORD from ENV, use shell default in HEALTHCHECK (#149)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vharseko <6818498+vharseko@users.noreply.github.com>
1 parent 0065483 commit 3beb3e8

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ LABEL org.opencontainers.image.authors="Open Identity Platform Community"
44

55
ENV USER="openidm"
66
ENV OPENIDM_OPTS="-server -XX:+UseContainerSupport --add-exports java.base/com.sun.jndi.ldap=ALL-UNNAMED -Dlogback.configurationFile=conf/logging-config.groovy"
7-
ENV OPENIDM_PASSWORD="openidm-admin"
87

98
ARG VERSION
109

@@ -29,6 +28,6 @@ EXPOSE 8080
2928

3029
USER $USER
3130

32-
HEALTHCHECK --interval=30s --timeout=30s --start-period=10s --retries=3 CMD curl -i -o - --silent --header "X-OpenIDM-Username: openidm-admin" --header "X-OpenIDM-Password: $OPENIDM_PASSWORD" http://127.0.0.1:8080/openidm/info/ping | grep -q "\"ACTIVE_READY\""
31+
HEALTHCHECK --interval=30s --timeout=30s --start-period=10s --retries=3 CMD curl -i -o - --silent --header "X-OpenIDM-Username: openidm-admin" --header "X-OpenIDM-Password: ${OPENIDM_PASSWORD:-openidm-admin}" http://127.0.0.1:8080/openidm/info/ping | grep -q "\"ACTIVE_READY\""
3332

3433
ENTRYPOINT ["/opt/openidm/startup.sh"]

Dockerfile-alpine

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ LABEL org.opencontainers.image.authors="Open Identity Platform Community"
44

55
ENV USER="openidm"
66
ENV OPENIDM_OPTS="-server -XX:+UseContainerSupport -Dlogback.configurationFile=conf/logging-config.groovy"
7-
ENV OPENIDM_PASSWORD="openidm-admin"
87

98
ARG VERSION
109

@@ -30,6 +29,6 @@ EXPOSE 8080
3029

3130
USER $USER
3231

33-
HEALTHCHECK --interval=30s --timeout=30s --start-period=10s --retries=3 CMD curl -i -o - --silent --header "X-OpenIDM-Username: openidm-admin" --header "X-OpenIDM-Password: $OPENIDM_PASSWORD" http://127.0.0.1:8080/openidm/info/ping | grep -q "\"ACTIVE_READY\""
32+
HEALTHCHECK --interval=30s --timeout=30s --start-period=10s --retries=3 CMD curl -i -o - --silent --header "X-OpenIDM-Username: openidm-admin" --header "X-OpenIDM-Password: ${OPENIDM_PASSWORD:-openidm-admin}" http://127.0.0.1:8080/openidm/info/ping | grep -q "\"ACTIVE_READY\""
3433

3534
ENTRYPOINT ["/opt/openidm/startup.sh"]

0 commit comments

Comments
 (0)