Commit a0c3465
authored
Use short-circuit && in Exchange.removeKeyRangeInternal (CodeQL java/non-short-circuit-evaluation) (#245)
The anti-value guard combined removeOnlyAntiValue with the isKeyRangeAntiValue
check using the non-short-circuit & operator, so isKeyRangeAntiValue was always
evaluated even when removeOnlyAntiValue was false. isKeyRangeAntiValue only reads
buffer state and has no side effects, so switching to && is behaviour-preserving
and skips the redundant call when the flag is already false.1 parent 77e436c commit a0c3465
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3700 | 3700 | | |
3701 | 3701 | | |
3702 | 3702 | | |
3703 | | - | |
| 3703 | + | |
3704 | 3704 | | |
3705 | 3705 | | |
3706 | 3706 | | |
| |||
0 commit comments