Remove never-read local variables (CodeQL java/local-variable-is-never-read) (#248)

Resolve 16 of the 18 alerts by removing local variables that are
assigned but never read, across 12 files. Side effects are preserved:
in IntegrityCheck both the shadowing _totalPages accumulator and its
update are dropped (pure getter, result unused); the AdminUI and
InspectorPanel blocks consumed no tokens read afterwards. Two alerts are
intentionally left: BufferPool's reserve (a deliberate 1 MB allocation
released under OutOfMemoryError) and ManagementTableModel's minWidth
(its assignment consumes a StringTokenizer token a later read depends
on). Verified by compiling every affected Maven module plus javac for
the persistit doc and example sources.

Author: vharseko

commons/doc-maven-plugin/src/main/java/org/forgerock/doc/maven/build/ChunkedHtml.java

@@ -12,6 +12,7 @@
  * information: "Portions copyright [year] [name of copyright owner]".
  *
  * Copyright 2012-2015 ForgeRock AS.
+ * Portions Copyrighted 2026 3A Systems, LLC
  */
 
 package org.forgerock.doc.maven.build;
@@ -110,8 +111,6 @@ void prepareOlinkDB() throws MojoExecutionException {
                 cfg.add(element(name("targetsFilename"), m.getDocumentSrcName() + ".html.target.db"));
 
                 final String base = FilenameUtils.getBaseName(m.getDocumentSrcName());
-                final String chunkBaseDir = m.path(m.getDocbkxOutputDirectory())
-                        + "/html/" + docName + "/" + base + "/";
                //cfg.add(element(name("chunkBaseDir"), chunkBaseDir));
 
                 executeMojo(
@@ -150,8 +149,6 @@ void build() throws MojoExecutionException {
                 cfg.add(element(name("includes"), docName + "/" + m.getDocumentSrcName()));
 
                 final String base = FilenameUtils.getBaseName(m.getDocumentSrcName());
-                final String chunkBaseDir = m.path(m.getDocbkxOutputDirectory())
-                        + "/html/" + docName + "/" + base + "/";
                 //cfg.add(element(name("chunkBaseDir"), chunkBaseDir));
 
                 cfg.add(element(name("manifest"),

commons/doc-maven-plugin/src/main/java/org/forgerock/doc/maven/utils/PngUtils.java

@@ -12,6 +12,7 @@
  * information: "Portions copyright [year] [name of copyright owner]".
  *
  * Copyright 2013-2015 ForgeRock AS.
+ * Portions Copyrighted 2026 3A Systems, LLC
  */
 
 package org.forgerock.doc.maven.utils;
@@ -76,7 +77,6 @@ public static void resizePng(final File image)
         final int imageHeight = getHeight(image);
         final int newWidth = 700;
 
-        String absolutePath = image.getAbsolutePath();
 
         /** File thumbFile = new File(absolutePath.substring(0, absolutePath
                 .lastIndexOf(File.separator)) + File.separator + "thumb_"

commons/http-framework/client-apache-async/src/main/java/org/forgerock/http/apache/async/AsyncHttpClientProvider.java

@@ -200,7 +200,6 @@ public HttpClient newHttpClient(final Options options) throws HttpApplicationExc
         }
 
         // Apply proxy settings if necessary
-        AuthenticationStrategy proxyStrategy = NoAuthenticationStrategy.INSTANCE;
         ProxyAuthenticationStrategy proxyAuthenticationStrategy = null;
 
         // Read the proxy info from options

commons/http-framework/client-apache-sync/src/main/java/org/forgerock/http/apache/sync/SyncHttpClientProvider.java

@@ -14,6 +14,7 @@
  * Copyright 2009 Sun Microsystems Inc.
  * Portions Copyright 2010–2011 ApexIdentity Inc.
  * Portions Copyright 2011-2015 ForgeRock AS.
+ * Portions Copyrighted 2026 3A Systems, LLC
  */
 
 package org.forgerock.http.apache.sync;
@@ -132,7 +133,6 @@ public HttpClient newHttpClient(final Options options) throws HttpApplicationExc
                 asArrayOrNull(ciphers), hostnameVerifier));
 
         // Apply proxy settings if necessary
-        AuthenticationStrategy proxyStrategy = NoAuthenticationStrategy.INSTANCE;
         ProxyAuthenticationStrategy proxyAuthenticationStrategy = null;
 
         // Read the proxy info from options

commons/rest/api-descriptor/src/main/java/org/forgerock/api/markup/asciidoc/AsciiDoc.java

@@ -281,7 +281,6 @@ public AsciiDoc blockTitle(final String title) {
      * @return Doc builder
      */
     public AsciiDoc sectionTitle(final String title, final int level) {
-        final AsciiDocSymbols symbol;
         // @Checkstyle:off
         switch (level) {
             case 1:

persistit/doc/build/src/AsciiDocIndex.java

@@ -170,7 +170,6 @@ private void indexOneTerm(final String wholeTag, String href, final String url,
                 String category = "Class";
                 if (title.startsWith("interface"))
                     category = "Interface";
-                final int pSlash = href.lastIndexOf('/', pHtml - 1);
                 // String className = href.substring(pSlash + 1, pHtml);
                 final String className = href.substring(0, pHtml).replace('/', '.');
                 saveTerm(category, className, url);
@@ -189,7 +188,6 @@ private void indexOneTerm(final String wholeTag, String href, final String url,
                     //
                     final String uCaseName = name.toUpperCase();
                     final String category = name.equals(uCaseName) ? "Constant" : "Field";
-                    final String displayText = name + " in " + className;
                     saveTerm(category, name, url);
                     return;
                 } else {
@@ -208,7 +206,6 @@ private void indexOneTerm(final String wholeTag, String href, final String url,
                     // String term = name.substring(0, pLeftParen);
                     String term = (href.substring(0, pHtml) + href.substring(pHtml + 5)).replace('/', '.');
                     saveTerm("Method", term, url);
-                    final String displayText = name + " in " + className;
                     if (name.startsWith("get") && paramList.length() == 0 || name.startsWith("is")
                             && paramList.length() == 0 || name.startsWith("set") && paramList.length() > 0
                             && paramList.indexOf(',') == -1) {

persistit/examples/FindFile/FindFile.java

@@ -209,7 +209,6 @@ private void doSearch() {
         sb.append("$");
         final Pattern pattern = Pattern.compile(sb.toString());
 
-        final DefaultListModel model = (DefaultListModel) list.getModel();
         //
         // Substring that precedes the first wildcard character. For example,
         // if the input is "/opt/*java", the prefix is "/opt/".

persistit/examples/SimpleDemo/SimpleDemo.java

@@ -12,6 +12,7 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ * Portions Copyrighted 2026 3A Systems, LLC
  */
 
 import java.io.BufferedReader;
@@ -65,7 +66,6 @@ public static void main(String[] args) throws Exception {
         System.out.println();
         BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
 
-        boolean done = false;
         int count = 0;
         while (true) {
             System.out.print("Name: ");

persistit/ui/src/main/java/com/persistit/ui/AdminUI.java

@@ -586,10 +586,6 @@ private void setupTabbedPanes() {
             final StringTokenizer st = new StringTokenizer(paneSpecification, ":");
             final String className = st.nextToken();
             final String caption = st.nextToken();
-            String iconName = null;
-            if (st.hasMoreTokens()) {
-                iconName = st.nextToken();
-            }
             try {
                 final Class cl = Class.forName(className);
                 final AdminPanel panel = (AdminPanel) cl.newInstance();

persistit/ui/src/main/java/com/persistit/ui/InspectorPanel.java

@@ -13,6 +13,7 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ * Portions Copyrighted 2026 3A Systems, LLC
  */
 
 package com.persistit.ui;
@@ -82,10 +83,6 @@ private void setupTabbedPanes() {
             final StringTokenizer st = new StringTokenizer(paneSpecification, ":");
             final String className = st.nextToken();
             final String caption = st.nextToken();
-            String iconName = null;
-            if (st.hasMoreTokens()) {
-                iconName = st.nextToken();
-            }
             try {
                 final Class cl = Class.forName(className);
                 final AbstractInspector panel = (AbstractInspector) cl.newInstance();