Skip to content

Commit 2cdaaf1

Browse files
authored
More sentry errors (#654)
* Always set complete to false when selecting new project * Protect againt `undefined.tier_1_reviewer`
1 parent d194e2d commit 2cdaaf1

2 files changed

Lines changed: 6 additions & 7 deletions

File tree

web_client/src/components/ProjectUsers.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ export default defineComponent({
2828
const collaborators = computed(
2929
() => currentProject.value.settings.permissions.collaborator as User[],
3030
);
31-
const members = computed(() => [
31+
const members = computed(() => (currentProject.value?.settings?.permissions ? [
3232
...currentProject.value.settings.permissions.tier_1_reviewer,
3333
...currentProject.value.settings.permissions.tier_2_reviewer,
34-
] as User[]);
34+
] as User[] : []));
3535
const emailOptions = computed(() => members.value.concat(collaborators.value).map(
3636
(u: User) => u.email,
3737
));
@@ -285,6 +285,7 @@ export default defineComponent({
285285
:dark="false"
286286
>
287287
<v-card
288+
v-if="selectedPermissionSet"
288289
class="dialog-box"
289290
>
290291
<v-btn

web_client/src/views/Projects.vue

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,7 @@ export default defineComponent({
118118
}
119119
}
120120
function selectProject(project: Project) {
121-
if (complete) {
122-
complete = false;
123-
}
121+
complete = false;
124122
store.dispatch('loadProject', project);
125123
}
126124
async function createProject() {
@@ -152,7 +150,7 @@ export default defineComponent({
152150
while (
153151
(!nextScan
154152
|| (nextScanState === 'complete' && reviewMode.value))
155-
&& nextProject.experiments[0].scans
153+
&& nextProject.experiments[0]?.scans
156154
&& nextScanIndex < nextProject.experiments[0].scans.length
157155
) {
158156
nextScan = nextProject.experiments[0].scans[nextScanIndex];
@@ -372,7 +370,7 @@ export default defineComponent({
372370
fill-height
373371
>
374372
<div
375-
v-if="complete"
373+
v-if="complete && currentProject"
376374
class="text-h6 text-center"
377375
>
378376
Viewed all scans in Project {{ currentProject.name }}.

0 commit comments

Comments
 (0)