Add translation injection support for bilingual knxprod generation#2
Open
akrabi wants to merge 2 commits into
Open
Add translation injection support for bilingual knxprod generation#2akrabi wants to merge 2 commits into
akrabi wants to merge 2 commits into
Conversation
Add TranslationHelper class that loads translation JSON files and injects <Languages> blocks into expanded XML before signing. SignHelper gains a translationsPath parameter on ExportKnxprod/ExportKnxprodAsync - when set, translations are injected in memory before SplitXml, producing bilingual knxprod files following the KNX standard TranslationUnit/TranslationElement structure. Key details: - LoadTranslations: accepts file or directory path, merges all JSON files - InjectTranslations: walks translatable elements (Parameters, ComObjects, CatalogItems, etc.), creates Translation entries for matching text - Multiple attributes per element supported (Text, Name, FunctionText, etc.) - Original cached XML is never modified (temp file used and cleaned up) - Backward compatible: empty translationsPath = existing behavior unchanged
Covers LoadTranslations (file, directory, recursive, merge, malformed JSON, empty values, nonexistent path) and InjectTranslations (parameter text, multi-attribute, catalog items, language identifier, element/attribute types, existing languages merge, duplicate suppression, null/missing root safety). Also updates .gitignore to use non-rooted patterns so bin/obj are excluded in subdirectories too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TranslationHelper class that loads translation JSON files and injects
blocks into expanded XML before signing. SignHelper gains a
translationsPath parameter on ExportKnxprod/ExportKnxprodAsync - when set,
translations are injected in memory before SplitXml, producing bilingual
knxprod files following the KNX standard TranslationUnit/TranslationElement
structure.
Key details:
CatalogItems, etc.), creates Translation entries for matching text