Skip to content

Add FREENECT_DEPTH_REGISTERED support to fakenect - #536

Merged
piedar merged 1 commit into
OpenKinect:masterfrom
Cwiiis:fakenect-depth-registration
Jan 11, 2018
Merged

Add FREENECT_DEPTH_REGISTERED support to fakenect#536
piedar merged 1 commit into
OpenKinect:masterfrom
Cwiiis:fakenect-depth-registration

Conversation

@Cwiiis

@Cwiiis Cwiiis commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

This allows use of depth mode FREENECT_DEPTH_REGISTERED with fakenect.

@piedar piedar added this to the v0.6.0 milestone Dec 1, 2017
Comment thread fakenect/fakenect.c Outdated
int freenect_get_depth_mode_count()
{
return 1;
return 2;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a (pre-existing) off-by-one error with the count here (my fault when enabling the _DEPTH_MM format) so this should be bumped to 3

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@Cwiiis
Cwiiis force-pushed the fakenect-depth-registration branch from 987232d to 035bc7d Compare January 11, 2018 15:14
@piedar
piedar merged commit 83e57e1 into OpenKinect:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants