Skip to content

Set video buffer in setVideoFormat - #572

Closed
spceaza wants to merge 2 commits into
OpenKinect:masterfrom
spceaza:video-format-cpp
Closed

Set video buffer in setVideoFormat#572
spceaza wants to merge 2 commits into
OpenKinect:masterfrom
spceaza:video-format-cpp

Conversation

@spceaza

@spceaza spceaza commented Dec 15, 2018

Copy link
Copy Markdown
Contributor

Signed-off-by: cesandovalp sandovalp.ce@gmail.com

Signed-off-by: cesandovalp <sandovalp.ce@gmail.com>
@piedar

piedar commented Dec 15, 2018

Copy link
Copy Markdown
Contributor

Does this improve performance? Also, looks like the buffer needs to be deleted in the destructor.

@spceaza

spceaza commented Dec 15, 2018

Copy link
Copy Markdown
Contributor Author

Does this improve performance? Also, looks like the buffer needs to be deleted in the destructor.

I'm an R programmer and I was making an interface for R, using the CPP wrapper, but when the resolution is changed I cannot get an RGB image, only a black screen. With this change I was able to get the image with different resolutions.

Signed-off-by: cesandovalp <sandovalp.ce@gmail.com>
@piedar piedar added this to the v0.6.0 milestone Dec 16, 2018
@piedar

piedar commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

Thanks! I took the first commit as 3bf6576, but I did the memory a little differently (d20b594). Please reopen if it doesn't solve your case.

@piedar piedar closed this Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants