Skip to content

Commit 18c0bc4

Browse files
committed
Pin effect to unblock repo typecheck
- Force a single `effect` version across `@effect/*` - Record the successful repo-wide `bun typecheck` in the rollout plan
1 parent bb25104 commit 18c0bc4

3 files changed

Lines changed: 9 additions & 15 deletions

File tree

.plans/web-i18n-rollout.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,17 @@ Completed so far:
4949
- Made timestamps honor the resolved app locale
5050
- Updated the timestamp callsites in chat and diff surfaces
5151
- Added Phase 1 guardrail tests for locale resolution, timestamp formatting, and catalog parity
52+
- Resolved the repo-wide server typecheck blocker by forcing a single `effect` version across `@effect/*`
5253
- `apps/web` tests pass
5354
- `bun fmt` passed
5455
- `bun lint` passed
56+
- `bun typecheck` passed
5557

5658
Not yet completed:
5759

5860
- Settings page migration
5961
- Onboarding migration
6062
- Mobile pairing migration
61-
- Repo-wide `bun typecheck` currently fails in `apps/server` on unrelated Effect/FileSystem context issues
6263

6364
## Phase 1 — Infrastructure
6465

@@ -167,7 +168,7 @@ Checklist:
167168
- [ ] Run `bun lint`
168169
- Status: `DONE`
169170
- [ ] Run `bun typecheck`
170-
- Status: `BLOCKED`
171+
- Status: `DONE`
171172

172173
Exit criteria:
173174

@@ -189,8 +190,7 @@ Phase 3 can follow later without blocking the first release if the app’s core
189190

190191
Immediate next implementation steps:
191192

192-
1. Resolve the unrelated `apps/server` typecheck failures so repo-wide verification can pass again.
193-
2. Migrate root route strings and root toasts.
194-
3. Migrate Settings and its supporting components.
195-
4. Migrate Onboarding and Mobile Pairing.
196-
5. Continue with Phase 2 completion toward the first shippable localized stop.
193+
1. Migrate root route strings and root toasts.
194+
2. Migrate Settings and its supporting components.
195+
3. Migrate Onboarding and Mobile Pairing.
196+
4. Continue with Phase 2 completion toward the first shippable localized stop.

bun.lock

Lines changed: 1 addition & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@
6666
"vitest": "catalog:"
6767
},
6868
"overrides": {
69+
"effect": "https://pkg.pr.new/Effect-TS/effect-smol/effect@8881a9b",
6970
"vite": "^8.0.0"
7071
},
7172
"lint-staged": {

0 commit comments

Comments
 (0)