Skip to content

Commit 2081022

Browse files
JonohobsBunsDev
authored andcommitted
fix: scope windows packaging workaround
1 parent 839964c commit 2081022

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ jobs:
105105
run: bun install --frozen-lockfile
106106

107107
- name: Build Windows desktop artifact
108-
run: bun run dist:desktop:win
108+
run: bun run dist:desktop:artifact -- --platform win --target nsis --arch x64 --verbose
109109

110110
- name: Upload Windows desktop artifact
111111
uses: actions/upload-artifact@v7

scripts/build-desktop-artifact.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -500,10 +500,6 @@ const createBuildConfig = Effect.fn("createBuildConfig")(function* (
500500
appId: "com.okcode.okcode",
501501
productName,
502502
artifactName: "OK-Code-${version}-${arch}.${ext}",
503-
// Production dependencies are installed into the staged app ahead of packaging.
504-
// Skip electron-builder's extra native rebuild step so packaged builds can use
505-
// shipped prebuilds like node-pty on Windows instead of requiring local Spectre libs.
506-
npmRebuild: false,
507503
directories: {
508504
buildResources: "apps/desktop/resources",
509505
},
@@ -557,6 +553,10 @@ const createBuildConfig = Effect.fn("createBuildConfig")(function* (
557553
if (signed) {
558554
winConfig.azureSignOptions = yield* AzureTrustedSigningOptionsConfig;
559555
} else {
556+
// Production dependencies are installed into the staged app ahead of packaging.
557+
// Skip electron-builder's extra native rebuild step so Windows builds can use
558+
// shipped prebuilds like node-pty instead of requiring local Spectre libs.
559+
buildConfig.npmRebuild = false;
560560
// Unsigned local builds shouldn't need the Windows code-signing toolchain or
561561
// rcedit metadata pass; skipping it avoids symlink-privileged cache extraction.
562562
winConfig.signAndEditExecutable = false;

0 commit comments

Comments
 (0)