Skip to content

Commit f700e92

Browse files
committed
Default new diff files to collapsed
- Make unrevealed diff files start collapsed in the review state - Update the DiffPanel fallback and tests to match the new default
1 parent 057fa60 commit f700e92

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

apps/web/src/components/DiffPanel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -679,7 +679,7 @@ export default function DiffPanel({ mode = "inline" }: DiffPanelProps) {
679679
const themedFileKey = `${fileKey}:${resolvedTheme}`;
680680
const fileReviewState = activeReviewState[filePath] ?? {
681681
accepted: false,
682-
collapsed: false,
682+
collapsed: true,
683683
};
684684
return (
685685
<DiffFileSection

apps/web/src/lib/diffFileReviewState.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ describe("reconcileDiffFileReviewState", () => {
1818
});
1919
});
2020

21-
it("initializes new files as unaccepted and expanded", () => {
21+
it("initializes new files as unaccepted and collapsed", () => {
2222
expect(reconcileDiffFileReviewState(["src/a.ts"], undefined)).toEqual({
23-
"src/a.ts": { accepted: false, collapsed: false },
23+
"src/a.ts": { accepted: false, collapsed: true },
2424
});
2525
});
2626
});
@@ -79,6 +79,7 @@ describe("expandDiffFile", () => {
7979
const state = {
8080
"src/a.ts": { accepted: false, collapsed: false },
8181
};
82+
// File is already expanded, so the same object reference is returned.
8283
expect(expandDiffFile(state, "src/a.ts")).toBe(state);
8384
});
8485
});

apps/web/src/lib/diffFileReviewState.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export interface DiffFileReviewState {
66
export type DiffFileReviewStateByPath = Record<string, DiffFileReviewState>;
77

88
const DEFAULT_DIFF_FILE_REVIEW_STATE: DiffFileReviewState = {
9-
collapsed: false,
9+
collapsed: true,
1010
accepted: false,
1111
};
1212

0 commit comments

Comments
 (0)