Centralize provider status copy and harden test/theme handling (#126)

* Centralize provider status copy and setup guidance

- Extract shared provider status presentation helpers
- Reuse headings, descriptions, and setup phase labels across chat UI
- Add tests for phase classification and auth-specific copy

* Pin Effect smol deps and fix custom theme parsing

- Add the shared Effect catalog override
- Merge theme vars directly when parsing Tweakcn JSON
- Remove an unused theme dialog import

* Disable Git signing in tests and harden theme root access

- Force `commit.gpgsign=false` in Git test helpers and fixtures
- Make theme application tolerate missing DOM root targets

* Resolve Electron binary in desktop smoke test

- Load Electron via `require("electron")` instead of a fixed `node_modules` path
- Fail fast with a clear error if the smoke test cannot launch Electron

Author: BunsDev

apps/desktop/scripts/smoke-test.mjs

@@ -1,11 +1,13 @@
 import { spawn } from "node:child_process";
+import { createRequire } from "node:module";
 import { dirname, resolve } from "node:path";
 import { fileURLToPath } from "node:url";
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const desktopDir = resolve(__dirname, "..");
-const electronBin = resolve(desktopDir, "node_modules/.bin/electron");
 const mainJs = resolve(desktopDir, "dist-electron/main.js");
+const require = createRequire(import.meta.url);
+const electronBin = require("electron");
 
 console.log("\nLaunching Electron smoke test...");
 
@@ -26,6 +28,13 @@ child.stderr.on("data", (chunk) => {
   output += chunk.toString();
 });
 
+child.on("error", (error) => {
+  clearTimeout(timeout);
+  console.error("\nDesktop smoke test failed to launch Electron:");
+  console.error(error);
+  process.exit(1);
+});
+
 const timeout = setTimeout(() => {
   child.kill();
 }, 8_000);

apps/server/integration/OrchestrationEngineHarness.integration.ts

@@ -74,6 +74,12 @@ function runGit(cwd: string, args: ReadonlyArray<string>) {
     cwd,
     stdio: ["ignore", "pipe", "pipe"],
     encoding: "utf8",
+    env: {
+      ...process.env,
+      GIT_CONFIG_COUNT: "1",
+      GIT_CONFIG_KEY_0: "commit.gpgsign",
+      GIT_CONFIG_VALUE_0: "false",
+    },
   });
 }
 

apps/server/src/git/Layers/GitCore.test.ts

@@ -21,6 +21,12 @@ const GitCoreTestLayer = GitCoreLive.pipe(
   Layer.provide(NodeServices.layer),
 );
 const TestLayer = Layer.mergeAll(NodeServices.layer, GitCoreTestLayer);
+const TEST_GIT_ENV = {
+  ...process.env,
+  GIT_CONFIG_COUNT: "1",
+  GIT_CONFIG_KEY_0: "commit.gpgsign",
+  GIT_CONFIG_VALUE_0: "false",
+};
 
 function makeTmpDir(
   prefix = "git-test-",
@@ -53,7 +59,7 @@ function git(
       operation: "GitCore.test.git",
       cwd,
       args,
-      ...(env ? { env } : {}),
+      env: env ? { ...TEST_GIT_ENV, ...env } : TEST_GIT_ENV,
       timeoutMs: 10_000,
     });
     return result.stdout.trim();
@@ -103,6 +109,7 @@ function initRepoWithCommit(
     yield* core.initRepo({ cwd });
     yield* git(cwd, ["config", "user.email", "test@test.com"]);
     yield* git(cwd, ["config", "user.name", "Test"]);
+    yield* git(cwd, ["config", "commit.gpgsign", "false"]);
     yield* writeTextFile(path.join(cwd, "README.md"), "# test\n");
     yield* git(cwd, ["add", "."]);
     yield* git(cwd, ["commit", "-m", "initial commit"]);
@@ -123,6 +130,7 @@ function initRepoWithCommitOnBranch(
     yield* git(cwd, ["init", `--initial-branch=${initialBranch}`]);
     yield* git(cwd, ["config", "user.email", "test@test.com"]);
     yield* git(cwd, ["config", "user.name", "Test"]);
+    yield* git(cwd, ["config", "commit.gpgsign", "false"]);
     yield* writeTextFile(path.join(cwd, "README.md"), "# test\n");
     yield* git(cwd, ["add", "."]);
     yield* git(cwd, ["commit", "-m", "initial commit"]);

apps/server/src/git/Layers/GitManager.test.ts

@@ -68,10 +68,18 @@ interface FakeGitTextGeneration {
 
 type FakePullRequest = NonNullable<FakeGhScenario["pullRequest"]>;
 
+const TEST_GIT_ENV = {
+  ...process.env,
+  GIT_CONFIG_COUNT: "1",
+  GIT_CONFIG_KEY_0: "commit.gpgsign",
+  GIT_CONFIG_VALUE_0: "false",
+};
+
 function runGitSyncForFakeGh(cwd: string, args: readonly string[]): void {
   const result = spawnSync("git", args, {
     cwd,
     encoding: "utf8",
+    env: TEST_GIT_ENV,
   });
   if (result.status === 0) {
     return;
@@ -132,6 +140,7 @@ function initRepo(
     yield* runGit(cwd, ["init", "--initial-branch=main"]);
     yield* runGit(cwd, ["config", "user.email", "test@example.com"]);
     yield* runGit(cwd, ["config", "user.name", "Test User"]);
+    yield* runGit(cwd, ["config", "commit.gpgsign", "false"]);
     yield* fs.writeFileString(path.join(cwd, "README.md"), "hello\n");
     yield* runGit(cwd, ["add", "README.md"]);
     yield* runGit(cwd, ["commit", "-m", "Initial commit"]);

apps/server/src/orchestration/Layers/CheckpointReactor.test.ts

@@ -163,6 +163,12 @@ function runGit(cwd: string, args: ReadonlyArray<string>) {
     cwd,
     stdio: ["ignore", "pipe", "pipe"],
     encoding: "utf8",
+    env: {
+      ...process.env,
+      GIT_CONFIG_COUNT: "1",
+      GIT_CONFIG_KEY_0: "commit.gpgsign",
+      GIT_CONFIG_VALUE_0: "false",
+    },
   });
 }
 

apps/server/src/workspaceEntries.test.ts

@@ -9,6 +9,12 @@ import { afterEach, assert, describe, it, vi } from "vitest";
 import { listWorkspaceDirectory, searchWorkspaceEntries } from "./workspaceEntries";
 
 const tempDirs: string[] = [];
+const TEST_GIT_ENV = {
+  ...process.env,
+  GIT_CONFIG_COUNT: "1",
+  GIT_CONFIG_KEY_0: "commit.gpgsign",
+  GIT_CONFIG_VALUE_0: "false",
+};
 
 function makeTempDir(prefix: string): string {
   const dir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
@@ -23,7 +29,7 @@ function writeFile(cwd: string, relativePath: string, contents = ""): void {
 }
 
 function runGit(cwd: string, args: string[]): void {
-  const result = spawnSync("git", args, { cwd, encoding: "utf8" });
+  const result = spawnSync("git", args, { cwd, encoding: "utf8", env: TEST_GIT_ENV });
   if (result.status !== 0) {
     throw new Error(result.stderr || `git ${args.join(" ")} failed`);
   }

apps/web/src/hooks/useTheme.ts

@@ -92,30 +92,66 @@ const FONT_FAMILY_MAP: Record<FontFamily, string> = {
     '"Plus Jakarta Sans", -apple-system, BlinkMacSystemFont, "Segoe UI", system-ui, sans-serif',
 };
 
+function getRootElement(): HTMLElement | null {
+  if (typeof document === "undefined") {
+    return null;
+  }
+
+  const root = document.documentElement;
+  if (!root) {
+    return null;
+  }
+
+  return root;
+}
+
+function hasStyleTarget(
+  root: HTMLElement | null,
+): root is HTMLElement & { style: CSSStyleDeclaration } {
+  return typeof root?.style?.setProperty === "function";
+}
+
+function hasClassListTarget(
+  root: HTMLElement | null,
+): root is HTMLElement & { classList: DOMTokenList } {
+  return (
+    typeof root?.classList?.add === "function" &&
+    typeof root.classList.remove === "function" &&
+    typeof root.classList.toggle === "function"
+  );
+}
+
 function applyFont(fontFamily?: FontFamily) {
   const font = fontFamily ?? getStoredFontFamily();
-  document.documentElement.style.setProperty("--font-ui", FONT_FAMILY_MAP[font]);
+  const root = getRootElement();
+  if (!hasStyleTarget(root)) {
+    return;
+  }
+  root.style.setProperty("--font-ui", FONT_FAMILY_MAP[font]);
 }
 
 function applyTheme(theme: Theme, suppressTransitions = false) {
+  const root = getRootElement();
+  if (!hasClassListTarget(root)) {
+    return;
+  }
+
   if (suppressTransitions) {
-    document.documentElement.classList.add("no-transitions");
+    root.classList.add("no-transitions");
   }
   const isDark = theme === "dark" || (theme === "system" && getSystemDark());
-  document.documentElement.classList.toggle("dark", isDark);
+  root.classList.toggle("dark", isDark);
 
   // Apply color theme class
   const colorTheme = getStoredColorTheme();
   // Remove any existing theme-* classes
-  const existingThemeClasses = Array.from(document.documentElement.classList).filter((cls) =>
-    cls.startsWith("theme-"),
-  );
+  const existingThemeClasses = Array.from(root.classList).filter((cls) => cls.startsWith("theme-"));
   for (const cls of existingThemeClasses) {
-    document.documentElement.classList.remove(cls);
+    root.classList.remove(cls);
   }
   // Add the new theme class if not default
   if (colorTheme !== "default") {
-    document.documentElement.classList.add(`theme-${colorTheme}`);
+    root.classList.add(`theme-${colorTheme}`);
   }
 
   // Apply font family
@@ -125,9 +161,9 @@ function applyTheme(theme: Theme, suppressTransitions = false) {
   if (suppressTransitions) {
     // Force a reflow so the no-transitions class takes effect before removal
     // oxlint-disable-next-line no-unused-expressions
-    document.documentElement.offsetHeight;
+    root.offsetHeight;
     requestAnimationFrame(() => {
-      document.documentElement.classList.remove("no-transitions");
+      root.classList.remove("no-transitions");
     });
   }
 }