Skip to content

Improve PR panel accessibility and keyboard shortcuts #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BunsDev merged 1 commit into from
Mar 31, 2026
Merged

Improve PR panel accessibility and keyboard shortcuts #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
206 changes: 115 additions & 91 deletions apps/web/src/components/pr-review/PrInspectorPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { NativeApi, PrConflictAnalysis, PrReviewConfig } from "@okcode/contracts";
import { useEffect, useRef, type ReactNode } from "react";
import { useId, type ReactNode } from "react";
import {
ChevronsLeftIcon,
ChevronsRightIcon,
Expand Down Expand Up @@ -27,96 +26,121 @@ export function PrInspectorPanel({
hasBlockedWorkflow: boolean;
children: ReactNode;
}) {
if (collapsed) {
return (
<div className="flex min-h-0 w-12 flex-col items-center border-l border-border/70 bg-background/96 py-2 gap-1">
<Button
size="icon-xs"
variant="ghost"
onClick={onToggleCollapsed}
title="Expand inspector"
className="mb-2"
>
<ChevronsLeftIcon className="size-4" />
</Button>
<Tooltip>
<TooltipTrigger
onClick={() => onExpandToTab?.("threads")}
render={
<button
type="button"
className="relative flex size-8 items-center justify-center rounded-lg text-muted-foreground transition-colors hover:bg-muted/50"
/>
}
>
<MessageSquareIcon className="size-4" />
{unresolvedThreadCount > 0 ? (
<span className="absolute -right-0.5 -top-0.5 flex size-4 items-center justify-center rounded-full bg-amber-500/20 text-[9px] font-bold text-amber-700 dark:text-amber-300">
{unresolvedThreadCount > 9 ? "9+" : unresolvedThreadCount}
</span>
) : null}
</TooltipTrigger>
<TooltipPopup side="left" sideOffset={8}>
Threads ({unresolvedThreadCount} open)
</TooltipPopup>
</Tooltip>
<Tooltip>
<TooltipTrigger
onClick={() => onExpandToTab?.("workflow")}
render={
<button
type="button"
className={cn(
"relative flex size-8 items-center justify-center rounded-lg transition-colors hover:bg-muted/50",
hasBlockedWorkflow
? "text-amber-600 dark:text-amber-400"
: "text-muted-foreground",
)}
/>
}
>
<SparklesIcon className="size-4" />
{hasBlockedWorkflow ? (
<span className="absolute right-1 top-1 size-1.5 rounded-full bg-amber-500" />
) : null}
</TooltipTrigger>
<TooltipPopup side="left" sideOffset={8}>
Workflow {hasBlockedWorkflow ? "(blocked)" : ""}
</TooltipPopup>
</Tooltip>
<Tooltip>
<TooltipTrigger
onClick={() => onExpandToTab?.("people")}
render={
<button
type="button"
className="flex size-8 items-center justify-center rounded-lg text-muted-foreground transition-colors hover:bg-muted/50"
/>
}
>
<UsersIcon className="size-4" />
</TooltipTrigger>
<TooltipPopup side="left" sideOffset={8}>
People
</TooltipPopup>
</Tooltip>
</div>
);
}
const panelId = useId();

return (
<div className="flex min-h-0 w-[360px] flex-col border-l border-border/70">
<div className="flex h-10 items-center justify-end px-2 border-b border-border/70">
<Button
size="icon-xs"
variant="ghost"
onClick={onToggleCollapsed}
title="Collapse inspector"
>
<ChevronsRightIcon className="size-4" />
</Button>
</div>
<div className="min-h-0 flex-1">{children}</div>
</div>
<aside
id={panelId}
aria-label="Pull request inspector"
className={cn(
"flex min-h-0 flex-col border-l border-border/70",
"transition-[width] duration-200 ease-in-out overflow-hidden",
collapsed ? "w-12 bg-background/96" : "w-[360px]",
)}
>
{collapsed ? (
/* ---------- Collapsed icon rail ---------- */
<div className="flex min-h-0 flex-1 w-12 shrink-0 flex-col items-center py-2 gap-1">
<Button
size="icon-xs"
variant="ghost"
onClick={onToggleCollapsed}
aria-expanded={false}
aria-controls={panelId}
aria-label="Expand inspector panel"
className="mb-2"
>
<ChevronsLeftIcon className="size-4" />
</Button>
<Tooltip>
<TooltipTrigger
onClick={() => onExpandToTab?.("threads")}
render={
<button
type="button"
aria-label={`Threads, ${unresolvedThreadCount} unresolved`}
className="relative flex size-8 items-center justify-center rounded-lg text-muted-foreground transition-colors hover:bg-muted/50"
/>
}
>
<MessageSquareIcon className="size-4" />
{unresolvedThreadCount > 0 ? (
<span
className="absolute -right-0.5 -top-0.5 flex size-4 items-center justify-center rounded-full bg-amber-500/20 text-[9px] font-bold text-amber-700 dark:text-amber-300"
aria-hidden="true"
>
{unresolvedThreadCount > 9 ? "9+" : unresolvedThreadCount}
</span>
) : null}
</TooltipTrigger>
<TooltipPopup side="left" sideOffset={8}>
Threads ({unresolvedThreadCount} open)
</TooltipPopup>
</Tooltip>
<Tooltip>
<TooltipTrigger
onClick={() => onExpandToTab?.("workflow")}
render={
<button
type="button"
aria-label={`Workflow${hasBlockedWorkflow ? ", blocked" : ""}`}
className={cn(
"relative flex size-8 items-center justify-center rounded-lg transition-colors hover:bg-muted/50",
hasBlockedWorkflow
? "text-amber-600 dark:text-amber-400"
: "text-muted-foreground",
)}
/>
}
>
<SparklesIcon className="size-4" />
{hasBlockedWorkflow ? (
<span
className="absolute right-1 top-1 size-1.5 rounded-full bg-amber-500"
aria-hidden="true"
/>
) : null}
</TooltipTrigger>
<TooltipPopup side="left" sideOffset={8}>
Workflow {hasBlockedWorkflow ? "(blocked)" : ""}
</TooltipPopup>
</Tooltip>
<Tooltip>
<TooltipTrigger
onClick={() => onExpandToTab?.("people")}
render={
<button
type="button"
aria-label="People"
className="flex size-8 items-center justify-center rounded-lg text-muted-foreground transition-colors hover:bg-muted/50"
/>
}
>
<UsersIcon className="size-4" />
</TooltipTrigger>
<TooltipPopup side="left" sideOffset={8}>
People
</TooltipPopup>
</Tooltip>
</div>
) : (
/* ---------- Expanded panel ---------- */
<>
<div className="flex h-10 items-center justify-end px-2 border-b border-border/70">
<Button
size="icon-xs"
variant="ghost"
onClick={onToggleCollapsed}
aria-expanded={true}
aria-controls={panelId}
aria-label="Collapse inspector panel"
>
<ChevronsRightIcon className="size-4" />
</Button>
</div>
<div className="min-h-0 flex-1">{children}</div>
</>
)}
</aside>
);
}
Loading
Loading