Skip to content

Refine WebSocket server keybinding and git progress tests#47

Merged
BunsDev merged 2 commits into
mainfrom
okcode/wsserver-keybindings-test
Mar 28, 2026
Merged

Refine WebSocket server keybinding and git progress tests#47
BunsDev merged 2 commits into
mainfrom
okcode/wsserver-keybindings-test

Conversation

@BunsDev

@BunsDev BunsDev commented Mar 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Tighten WebSocket server keybinding assertions to compare the resolved terminal.toggle binding directly.
  • Improve test stub typing for runStackedAction to better match the git manager shape.
  • Clean up call inspection in the connection logging test for clearer destructuring.

Testing

  • Not run (PR content only).
  • Existing repository checks should still be run as required: bun fmt, bun lint, bun typecheck.

BunsDev added 2 commits March 27, 2026 22:25
…bSocket server tests

- Update imports in wsServer.test.ts to include GitActionProgressReporter for better type handling.
- Refine type assertions in logSpy mock calls to ensure correct message types.
- Modify keybinding assertions to validate specific command bindings and ensure non-existent commands are excluded.
- Simplify keybinding assertion with a named invalid command
- Tighten git action progress stub to use the request input
@vercel

vercel Bot commented Mar 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
okcode-marketing Ready Ready Preview Mar 28, 2026 3:30am

@BunsDev BunsDev merged commit 3f75cb5 into main Mar 28, 2026
8 of 9 checks passed
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Mar 28, 2026
@BunsDev BunsDev deleted the okcode/wsserver-keybindings-test branch March 31, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant