Skip to content

Add structured Git action failures and retry UI#55

Merged
BunsDev merged 2 commits into
mainfrom
okcode/github-error-handling
Mar 28, 2026
Merged

Add structured Git action failures and retry UI#55
BunsDev merged 2 commits into
mainfrom
okcode/github-error-handling

Conversation

@BunsDev
Copy link
Copy Markdown
Member

@BunsDev BunsDev commented Mar 28, 2026

Summary

  • Introduce structured GitActionFailure reporting for stacked git actions on the server, with phase-aware classification for common cases like detached HEAD, branch protection, missing gh, auth failures, and hook rejections.
  • Return richer WebSocket errors for git action failures so the web client can render actionable messages and preserve structured failure data.
  • Add a failure review dialog and retry flow in the git actions UI, including better toast copy and phase-specific retry labels.
  • Tighten several shared UI primitives and update related tests and error expectations across server, contracts, and web.

Testing

  • Not run (PR content only).
  • Existing/added unit coverage updated for git failure classification, WebSocket serialization, git action control logic, and server error handling.
  • Repository checks expected to pass: bun fmt, bun lint, bun typecheck.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
okcode-marketing Ready Ready Preview Mar 28, 2026 6:03am

@github-actions github-actions Bot added size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Mar 28, 2026
BunsDev added 2 commits March 28, 2026 00:59
- Introduce GitActionExecutionError for structured error handling in git actions.
- Update WebSocket server to serialize Git action errors with detailed failure information.
- Enhance client-side handling of WebSocket errors to preserve structured error data.
- Add utility functions for summarizing and resolving Git action failures in the UI.
- Improve tests to cover new error handling scenarios and ensure proper decoding of structured errors.
- Switch dialogs to Base UI primitives and update close handling
- Add richer button/input composition for shared component use
- Tweak destructive actions and GitHub review link rendering
@BunsDev BunsDev force-pushed the okcode/github-error-handling branch from 8ea9eeb to 952aa0a Compare March 28, 2026 06:03
@github-actions github-actions Bot added size:XL and removed size:XXL labels Mar 28, 2026
@BunsDev BunsDev merged commit 74d5e1d into main Mar 28, 2026
8 of 9 checks passed
@BunsDev BunsDev deleted the okcode/github-error-handling branch March 28, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant