Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions apps/server/src/terminal/Layers/Manager.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { EventEmitter } from "node:events";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";

import {
Expand Down Expand Up @@ -536,7 +537,12 @@ export class TerminalManagerRuntime extends EventEmitter<TerminalManagerEvents>
async open(raw: TerminalOpenInput): Promise<TerminalSessionSnapshot> {
const input = decodeTerminalOpenInput(raw);
return this.runWithThreadLock(input.threadId, async () => {
await this.assertValidCwd(input.cwd);
let cwd = input.cwd;
try {
await this.assertValidCwd(cwd);
} catch {
cwd = os.homedir();
}

const sessionKey = toSessionKey(input.threadId, input.terminalId);
const existing = this.sessions.get(sessionKey);
Expand All @@ -548,7 +554,7 @@ export class TerminalManagerRuntime extends EventEmitter<TerminalManagerEvents>
const session: TerminalSessionState = {
threadId: input.threadId,
terminalId: input.terminalId,
cwd: input.cwd,
cwd,
status: "starting",
pid: null,
history,
Expand All @@ -566,7 +572,7 @@ export class TerminalManagerRuntime extends EventEmitter<TerminalManagerEvents>
};
this.sessions.set(sessionKey, session);
this.evictInactiveSessionsIfNeeded();
await this.startSession(session, { ...input, cols, rows }, "started");
await this.startSession(session, { ...input, cwd, cols, rows }, "started");
return this.snapshot(session);
}

Expand All @@ -577,9 +583,9 @@ export class TerminalManagerRuntime extends EventEmitter<TerminalManagerEvents>
const runtimeEnvChanged =
JSON.stringify(currentRuntimeEnv) !== JSON.stringify(nextRuntimeEnv);

if (existing.cwd !== input.cwd || runtimeEnvChanged) {
if (existing.cwd !== cwd || runtimeEnvChanged) {
this.stopProcess(existing);
existing.cwd = input.cwd;
existing.cwd = cwd;
existing.runtimeEnv = nextRuntimeEnv;
existing.history = "";
existing.pendingHistoryControlSequence = "";
Expand All @@ -596,7 +602,7 @@ export class TerminalManagerRuntime extends EventEmitter<TerminalManagerEvents>
if (!existing.process) {
await this.startSession(
existing,
{ ...input, cols: targetCols, rows: targetRows },
{ ...input, cwd, cols: targetCols, rows: targetRows },
"started",
);
return this.snapshot(existing);
Expand Down Expand Up @@ -661,7 +667,12 @@ export class TerminalManagerRuntime extends EventEmitter<TerminalManagerEvents>
async restart(raw: TerminalRestartInput): Promise<TerminalSessionSnapshot> {
const input = decodeTerminalRestartInput(raw);
return this.runWithThreadLock(input.threadId, async () => {
await this.assertValidCwd(input.cwd);
let cwd = input.cwd;
try {
await this.assertValidCwd(cwd);
} catch {
cwd = os.homedir();
}

const sessionKey = toSessionKey(input.threadId, input.terminalId);
let session = this.sessions.get(sessionKey);
Expand All @@ -671,7 +682,7 @@ export class TerminalManagerRuntime extends EventEmitter<TerminalManagerEvents>
session = {
threadId: input.threadId,
terminalId: input.terminalId,
cwd: input.cwd,
cwd,
status: "starting",
pid: null,
history: "",
Expand All @@ -691,7 +702,7 @@ export class TerminalManagerRuntime extends EventEmitter<TerminalManagerEvents>
this.evictInactiveSessionsIfNeeded();
} else {
this.stopProcess(session);
session.cwd = input.cwd;
session.cwd = cwd;
session.runtimeEnv = normalizedRuntimeEnv(input.env);
}

Expand All @@ -701,7 +712,7 @@ export class TerminalManagerRuntime extends EventEmitter<TerminalManagerEvents>
session.history = "";
session.pendingHistoryControlSequence = "";
await this.persistHistory(input.threadId, input.terminalId, session.history);
await this.startSession(session, { ...input, cols, rows }, "restarted");
await this.startSession(session, { ...input, cwd, cols, rows }, "restarted");
return this.snapshot(session);
});
}
Expand Down
4 changes: 4 additions & 0 deletions apps/server/src/wsServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1202,6 +1202,10 @@ export const createServer = Effect.fn(function* (): Effect.fn.Return<
};
}

if (squashed instanceof Error) {
return { message: squashed.message };
}

return { message: Cause.pretty(cause) };
};

Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/ThreadTerminalDrawer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function clampDrawerHeight(height: number): number {
}

function writeSystemMessage(terminal: Terminal, message: string): void {
terminal.write(`\r\n[terminal] ${message}\r\n`);
terminal.write(`\r\n\x1b[33m⚠ ${message}\x1b[0m\r\n`);
}

function terminalThemeFromApp(): ITheme {
Expand Down
Loading