OLMIS-8257: Guard against missing window.applicationCache in app-cache controller#87
Merged
mgrochalskisoldevelo merged 1 commit intoJul 17, 2026
Conversation
denys1204
requested review from
kszymankiewicz-sd,
lwojewnik and
mgrochalskisoldevelo
July 16, 2026 14:02
|
mgrochalskisoldevelo
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fix
OpenlmisAppCacheControllercrashing whenwindow.applicationCacheis unavailable, which prevented the "Software last updated on" build date from rendering in the header.Problem
The AppCache API (
window.applicationCache) has been removed from modern browsers, so$window.applicationCacheisundefined.$onInitcalledappCache.addEventListenerbefore assigningvm.buildDate, throwing aTypeErrorand leavingvm.buildDateunset — so the build date never appeared.Change
window.applicationCache($onInitlistener registration andsetUpdateReady).$onInitnow completes and setsvm.buildDate; the cache-update flow safely no-ops when AppCache is absent.applicationCachecase.Testing
grunt build: lint clean, all unit tests pass (946/946).Reference: originally fixed in the Eswatini distribution (OE-213), now moved upstream.