Skip to content

Trans timeout batch#34873

Draft
Arunkumar-Kallyodan wants to merge 3 commits into
OpenLiberty:integrationfrom
Arunkumar-Kallyodan:trans_timeout_batch
Draft

Trans timeout batch#34873
Arunkumar-Kallyodan wants to merge 3 commits into
OpenLiberty:integrationfrom
Arunkumar-Kallyodan:trans_timeout_batch

Conversation

@Arunkumar-Kallyodan
Copy link
Copy Markdown
Contributor

According to the Jakarta Batch specification 2.0 ([link to spec), the correct property key for setting the global transaction timeout is:

jakarta.transaction.global.timeout

However, the current implementation in OpenLiberty appears to still reference the legacy javax key instead.

Fix

The implementation should check for jakarta.transaction.global.timeout in alignment with the Jakarta EE 10+ specifications. Updated ChunkStepControllerImpl.initStepTransactionTimeout() to check for jakarta.transaction.global.timeout property first, then fall back to javax.transaction.global.timeout for backward compatibility.

@Arunkumar-Kallyodan
Copy link
Copy Markdown
Contributor Author

Arunkumar-Kallyodan commented May 12, 2026

!build (view Open Liberty Personal Build - ⚠️ completed with warnings.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link
Copy Markdown
Member

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

Copy link
Copy Markdown
Member

@dmbelina dmbelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the jakarta property check needs to be accompanied by an EE level check since technically that property is not valid for EE8.

So:
if(eelevel > 8) look for jakarta property.

if we didn’t find jakarta prop, look for javax

For the logging message that was changed, we should know what prop we’re using, so this log message could be dynamic

Also, we should add a test for when this runs on EE>8 to use the jakarta prop.

@Arunkumar-Kallyodan
Copy link
Copy Markdown
Contributor Author

Arunkumar-Kallyodan commented May 14, 2026

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link
Copy Markdown
Member

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link
Copy Markdown
Member

The following files contain comments noting GenAI assistance:

  • dev/com.ibm.ws.jbatch.open_fat/fat/src/batch/fat/junit/TranTimeoutJakartaTest.java
  • dev/com.ibm.ws.jbatch.open_fat/test-applications/batchFAT.war/resources/WEB-INF/classes/META-INF/batch-jobs/ChunkTranTimeoutJakarta.xml
  • dev/com.ibm.ws.jbatch.open_fat/test-applications/batchFAT.war/src/batch/fat/web/customlogic/TranTimeoutJakartaServlet.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants