Trans timeout batch#34873
Conversation
|
!build (view Open Liberty Personal Build - Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
dmbelina
left a comment
There was a problem hiding this comment.
I think the jakarta property check needs to be accompanied by an EE level check since technically that property is not valid for EE8.
So:
if(eelevel > 8) look for jakarta property.
if we didn’t find jakarta prop, look for javax
For the logging message that was changed, we should know what prop we’re using, so this log message could be dynamic
Also, we should add a test for when this runs on EE>8 to use the jakarta prop.
|
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
The following files contain comments noting GenAI assistance:
|
According to the Jakarta Batch specification 2.0 ([link to spec), the correct property key for setting the global transaction timeout is:
jakarta.transaction.global.timeoutHowever, the current implementation in OpenLiberty appears to still reference the legacy javax key instead.
Fix
The implementation should check for
jakarta.transaction.global.timeoutin alignment with the Jakarta EE 10+ specifications. Updated ChunkStepControllerImpl.initStepTransactionTimeout() to check for jakarta.transaction.global.timeout property first, then fall back to javax.transaction.global.timeout for backward compatibility.