Trace update to ApplicationManager.java#34891
Open
tbitonti wants to merge 1 commit into
Open
Conversation
Preperatory changes for updating how the extraction log is managed.
rsherget
reviewed
May 14, 2026
| // TODO: This check for a class cast exception seems unnecessary: | ||
| // Configuration metadata type should always put properly | ||
| // typed values. | ||
| value = deflt; |
Member
There was a problem hiding this comment.
Is this needed? Why not keep T value = deflt; from the original
| writeCase = "Removing unused extraction log"; | ||
|
|
||
| // TODO: Is this correct? Discarding the log forces the | ||
| // applications to be re-expanded. |
Member
There was a problem hiding this comment.
Looks right, only happens if we have the extractsLog file but autoExpand is false. Shouldn't have the extractsLog file in this case
| if ( prop != null ) { | ||
| value = prop; | ||
| } else { | ||
| value = deflt; // Assign the default if present and null. |
Member
There was a problem hiding this comment.
redundant if you just keep T value = deflt from the original
| * | ||
| * This is used for normal activation and for configuration updates. | ||
| * | ||
| * TODO: Enabling auto-expand does NOT cause the extraction data |
Member
There was a problem hiding this comment.
Going from autoExpand=false to autoExpand=true means no extractedLog file, so no issue there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preperatory changes for updating how the extraction log is managed.
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).################################################################################################
Delete this section and fill in the remaining info from the template
ATTENTION, READ THIS: Updated July 2024
Read and understand this completely, then delete the static part of the template.
If a reviewer or merger sees this template, they should fail the review or merge.
If this code change is fixing a user-visible bug in previously released code, it MUST
have an associated issue mentioned in the PR text or description.
That Issue also MUST be labelled “release bug”
This directs automation to scrape this fix for inclusion in the next release's
list of bugs fixed.
The linkage between PR and Issue should use the
Fixes #...syntax rather than a manuallink via the Development widget.
Otherwise, a link to an issue or specific issue labels are optional.
For full details, please see this wiki page: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions
################################################################################################