Nanoleaf Panel id outdated

[SaiCode-DEV]

My Panel ID from one of my Nanoleafs is 54510, and i always get the error invaid value returned. (plugins/nanoleaf/NanoleafDevice.cpp:82)

it seems the variable for panels is too small for new gens. (uint_8_t => max 255)

[SaiCode-DEV]

i tried myself to change it to uint_32_t , but build fails

[peternewman]

My Panel ID from one of my Nanoleafs is 54510, and i always get the error invaid value returned. (plugins/nanoleaf/NanoleafDevice.cpp:82)

it seems the variable for panels is too small for new gens. (uint_8_t => max 255)

Are they one of the new shapes like square or something?

i tried myself to change it to uint_32_t , but build fails

What error do you get? You'll need to change the other panels related variable in that function, and the NanoleafNode class.

The real question is how this impacts the animation sending code in here:

ola/plugins/nanoleaf/NanoleafNode.cpp

Lines 117 to 120 in b666b6f

	m_output_stream << m_panels[i] << NANOLEAF_FRAME_COUNT;
	m_output_stream.Write(buffer.GetRaw() + (i * NANOLEAF_SLOTS_PER_PANEL),
	NANOLEAF_SLOTS_PER_PANEL);
	m_output_stream << NANOLEAF_WHITE_LEVEL << NANOLEAF_TRANSITION_TIME;

If that has a completely new format then it will need a bit more rewriting than just changing the size of a field in a few places...

[SaiCode-DEV]

Are they one of the new shapes like square or something?
They are the Hexagons, i bought 60 of them and it would be super cool to get it working.

If you have any ideas, i will try them out.

i am not good in programming, but i know that uint8_t is too small, and the programm only allows max 255 as the panel id

[peternewman]

Okay, so I've checked the docs:

Please note the Light panels support streaming control version v1 and v2. Canvas supports stream control version v2 and requires specifying the version in the request. If the extControlVersion key is omitted, v1 is assumed, which would return an error for Canvas.

Light Panels and Canvas use a different external control streaming protocols. Light Panels uses stream control v1 or v2, while Canvas uses stream control v2.

In order to support the much larger number of panels on Canvas, the size of the nPanels, panelId and tranitionTime fields have been increased from 1B to 2B. The nFrames field has been dropped as it was set to 1 in v1 anyway

Note that all the multi-byte fields are represented in Big Endian format

From https://forum.nanoleaf.me/docs/openapi (behind a registration wall).

So it should be fairly easy to fix (or ideally support both), you also get the ability to control the white individually too if you want. Unfortunately I can't work on it for a little while, so either have a go at hacking around with it yourself, or I'll pick it up when I can.

This would also want linking into #1390 and/or #1485

[peternewman]

Hi @SaiBot-YT

Give this a go:
#1738

I think it should do the trick, if you can test it and let us know would be good.

[peternewman]

@SaiBot-YT have you had a chance to look at this yet?

[peternewman]

Ping @SaiBot-YT are you still interested in testing this?