Updated Nanoleaf plugin Readme with better directions#1609
Open
miniman13 wants to merge 10 commits into
Open
Conversation
Updated Readme with better directions on how to use nanoleaf plugin, enabling udp mode and api to do so
peternewman
requested changes
Jan 30, 2020
Member
There was a problem hiding this comment.
Thanks for this @miniman13 it's really appreciated.
Just some minor tweaks if you wouldn't mind?
peternewman
reviewed
Jan 30, 2020
Fixed Changes requested here: https://github.com/OpenLightingProject/ola/pull/1609/files
peternewman
reviewed
Jul 28, 2021
| (for Red, Green and Blue). | ||
| The list of panel IDs to control, each panel is mapped to three DMX512 | ||
| slots (for Red, Green and Blue). | ||
| Panel IDs are comma separated eg: `321,789,123` |
Member
There was a problem hiding this comment.
I've just noticed off the back of #1730 these example values are invalid for the v1 protocol. We'd want say (to show order is irrelevant):
Suggested change
| Panel IDs are comma separated eg: `321,789,123` | |
| Panel IDs are comma separated eg: `132,178,54` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Readme with better directions on how to use nanoleaf plugin, enabling udp mode and api to do so