Add a Channel Remap Tool#1895
Add a Channel Remap Tool#1895peternewman wants to merge 7 commits intoOpenLightingProject:masterfrom
Conversation
kripton
left a comment
kripton
left a comment
There was a problem hiding this comment.
The file format/contents could you some more explanatory comments
| } | ||
|
|
||
| uint16_t Channel() const { return m_channel + 1; } | ||
| void Channel(uint16_t channel) { m_channel = channel - 1; } |
There was a problem hiding this comment.
should we limit the channel to valid channel numbers? it's a uint16 but values above 511 proabably don't make sense
There was a problem hiding this comment.
Makes sense (and -1). We should do it in the base zero based class too:
https://github.com/OpenLightingProject/ola/pull/1895/changes#diff-8fc0933696876a24c2305a4ad549a22bfbef87cab256596b7a5cd76fb34df2e9R112
| examples/ola_ptch.exe | ||
| examples/ola_patcher_remap | ||
| examples/ola_patcher_remap.exe | ||
| examples/ola_ptcher_remap.exe |
There was a problem hiding this comment.
why do we have the file with the a missing?
There was a problem hiding this comment.
Because Windows. I don't know whether patcher will avoid it off the top of my head, but better safe than sorry potentially...
Lines 111 to 116 in c6196f7
| } | ||
|
|
||
| ~DmxRemap() { | ||
| // TODO(Peter): Delete everything |
There was a problem hiding this comment.
should be implemented before merging
2 participants
Uh oh!
There was an error while loading. Please reload this page.