test(drivers/139): cover live login authorization paths

Author: UcnacDx2

drivers/139/util.go

@@ -1035,6 +1035,21 @@ func (d *Yun139) step2_get_single_token(sid string) (string, error) {
 
 	dycpwd := jsoniter.Get(res.Body(), "var", "artifact").ToString()
 	if dycpwd == "" {
+		code := jsoniter.Get(res.Body(), "code").ToString()
+		summary := jsoniter.Get(res.Body(), "summary").ToString()
+		if code == "" {
+			if match := regexp.MustCompile(`['"]code['"]\s*:\s*['"]([^'"]+)['"]`).FindSubmatch(res.Body()); len(match) == 2 {
+				code = string(match[1])
+			}
+		}
+		if summary == "" {
+			if match := regexp.MustCompile(`['"]summary['"]\s*:\s*['"]([^'"]+)['"]`).FindSubmatch(res.Body()); len(match) == 2 {
+				summary = string(match[1])
+			}
+		}
+		if code != "" || summary != "" {
+			return "", fmt.Errorf("failed to extract dycpwd from artifact exchange response: code=%s summary=%s", code, summary)
+		}
 		return "", errors.New("failed to extract dycpwd from artifact exchange response")
 	}
 	log.Debugf("DEBUG: dycpwd extracted from artifact exchange response.")
@@ -1376,6 +1391,9 @@ func (d *Yun139) credentialState() (credentialState, error) {
 	d.MailCookies = strings.TrimSpace(d.MailCookies)
 
 	if d.Authorization != "" {
+		if strings.HasPrefix(strings.ToLower(d.Authorization), "basic ") {
+			return 0, fmt.Errorf("authorization should not include Basic prefix")
+		}
 		return credentialStateAuthorization, nil
 	}
 

drivers/139/util_test.go

@@ -2,7 +2,13 @@ package _139
 
 import (
 	"net/http"
+	"os"
+	"strings"
 	"testing"
+	"time"
+
+	"github.com/OpenListTeam/OpenList/v4/drivers/base"
+	"github.com/go-resty/resty/v2"
 )
 
 func TestSanitizeLoginCookiesReplacesJSessionIDAndOrdersAllowlist(t *testing.T) {
@@ -81,6 +87,11 @@ func TestCredentialState(t *testing.T) {
 			d:    Yun139{Addition: Addition{MailCookies: "invalid-cookie"}},
 			err:  true,
 		},
+		{
+			name: "authorization with basic prefix",
+			d:    Yun139{Addition: Addition{Authorization: "Basic abc"}},
+			err:  true,
+		},
 	}
 
 	for _, tt := range tests {
@@ -102,6 +113,141 @@ func TestCredentialState(t *testing.T) {
 	}
 }
 
+func TestIntegrationLoginObtainsAuthorization(t *testing.T) {
+	if os.Getenv("OPENLIST_139_INTEGRATION") != "1" {
+		t.Skip("set OPENLIST_139_INTEGRATION=1 to run live 139Yun login checks")
+	}
+	base.RestyClient = resty.New().
+		SetHeader("user-agent", base.UserAgent).
+		SetRetryCount(3).
+		SetRetryResetReaders(true).
+		SetTimeout(30 * time.Second)
+
+	username := os.Getenv("OPENLIST_139_USERNAME")
+	password := os.Getenv("OPENLIST_139_PASSWORD")
+	mailCookies := os.Getenv("OPENLIST_139_MAIL_COOKIES")
+	authorization := strings.TrimSpace(os.Getenv("OPENLIST_139_AUTHORIZATION"))
+
+	if authorization != "" {
+		t.Run("authorization", func(t *testing.T) {
+			d := Yun139{Addition: Addition{Authorization: authorization}}
+			state, err := d.credentialState()
+			if err != nil {
+				t.Fatalf("credentialState() unexpected error: %v", err)
+			}
+			if state != credentialStateAuthorization {
+				t.Fatalf("credentialState() = %v, want authorization", state)
+			}
+			if d.Authorization == "" || strings.HasPrefix(strings.ToLower(d.Authorization), "basic ") {
+				t.Fatal("authorization should be present without Basic prefix")
+			}
+		})
+	}
+
+	if mailCookies == "" {
+		t.Fatal("OPENLIST_139_MAIL_COOKIES is required")
+	}
+
+	runFastLogin := func(t *testing.T, mailCookies string) {
+		t.Helper()
+		d := Yun139{Addition: Addition{MailCookies: mailCookies}}
+		state, err := d.credentialState()
+		if err != nil {
+			t.Fatalf("credentialState() unexpected error: %v", err)
+		}
+		if state != credentialStateCookiesOnly {
+			t.Fatalf("credentialState() = %v, want cookies only", state)
+		}
+		sid, rmkey := extractFastLoginCookies(d.MailCookies)
+		if sid == "" || rmkey == "" {
+			t.Fatal("mail cookies are missing Os_SSo_Sid or RMKEY")
+		}
+		token, err := d.step2_get_single_token(sid)
+		if err != nil {
+			t.Fatalf("step2_get_single_token() error: %v", err)
+		}
+		auth, err := d.step3_third_party_login(token)
+		if err != nil {
+			t.Fatalf("step3_third_party_login() error: %v", err)
+		}
+		d.Authorization = auth
+		if d.Authorization == "" {
+			t.Fatal("authorization is empty after fast login")
+		}
+	}
+
+	if username == "" || password == "" {
+		t.Fatal("OPENLIST_139_USERNAME and OPENLIST_139_PASSWORD are required for password fallback")
+	}
+
+	var refreshedMailCookies string
+	var generatedAuthorization string
+	t.Run("password login fallback", func(t *testing.T) {
+		d := Yun139{Addition: Addition{
+			MailCookies: mailCookies,
+			Username:    username,
+			Password:    password,
+		}}
+		state, err := d.credentialState()
+		if err != nil {
+			t.Fatalf("credentialState() unexpected error: %v", err)
+		}
+		if state != credentialStateFullLogin {
+			t.Fatalf("credentialState() = %v, want full login", state)
+		}
+		passId, err := d.step1_password_login()
+		if err != nil {
+			t.Fatalf("step1_password_login() error: %v", err)
+		}
+		token, err := d.step2_get_single_token(passId)
+		if err != nil {
+			t.Fatalf("step2_get_single_token() error: %v", err)
+		}
+		auth, err := d.step3_third_party_login(token)
+		if err != nil {
+			t.Fatalf("step3_third_party_login() error: %v", err)
+		}
+		d.Authorization = auth
+		if auth == "" || d.Authorization == "" {
+			t.Fatal("authorization is empty after password login")
+		}
+		generatedAuthorization = auth
+		refreshedMailCookies = d.MailCookies
+	})
+
+	t.Run("authorization generated by password login", func(t *testing.T) {
+		if generatedAuthorization == "" {
+			t.Fatal("password login did not generate authorization")
+		}
+		d := Yun139{Addition: Addition{Authorization: generatedAuthorization}}
+		state, err := d.credentialState()
+		if err != nil {
+			t.Fatalf("credentialState() unexpected error: %v", err)
+		}
+		if state != credentialStateAuthorization {
+			t.Fatalf("credentialState() = %v, want authorization", state)
+		}
+		if strings.HasPrefix(strings.ToLower(d.Authorization), "basic ") {
+			t.Fatal("authorization should not include Basic prefix")
+		}
+	})
+
+	t.Run("mail cookies fast login from input", func(t *testing.T) {
+		sid, rmkey := extractFastLoginCookies(mailCookies)
+		if sid == "" || rmkey == "" {
+			t.Skip("input mail cookies are missing Os_SSo_Sid or RMKEY")
+		}
+		runFastLogin(t, mailCookies)
+	})
+
+	t.Run("mail cookies fast login after password login", func(t *testing.T) {
+		if refreshedMailCookies == "" {
+			t.Fatal("password login did not refresh mail cookies")
+		}
+		runFastLogin(t, refreshedMailCookies)
+	})
+}
+
 func TestIsRedirectStatus(t *testing.T) {
 	for _, status := range []int{300, 301, 302, 307, 399} {
 		if !isRedirectStatus(status) {