fix(drivers/webdav): normalize missing path error (#2611)

Normalize WebDAV 404 responses from `Stat` to `errs.ObjectNotFound`.

This fixes the mkdir pre-check path: when the target folder does not exist, `op.MakeDir` can now treat the lookup as a normal missing object and continue to issue `MKCOL` through the WebDAV driver.

Co-authored-by: ChatGPT <noreply@openai.com>

Author: fwerkor

drivers/webdav/driver.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/OpenListTeam/OpenList/v4/drivers/base"
 	"github.com/OpenListTeam/OpenList/v4/internal/driver"
+	"github.com/OpenListTeam/OpenList/v4/internal/errs"
 	"github.com/OpenListTeam/OpenList/v4/internal/model"
 	"github.com/OpenListTeam/OpenList/v4/pkg/cron"
 	"github.com/OpenListTeam/OpenList/v4/pkg/gowebdav"
@@ -130,6 +131,9 @@ func (d *WebDav) Get(ctx context.Context, _path string) (model.Obj, error) {
 	_path = path.Join(d.GetRootPath(), _path)
 	info, err := d.client.Stat(_path)
 	if err != nil {
+		if gowebdav.IsErrNotFound(err) {
+			return nil, errs.ObjectNotFound
+		}
 		return nil, err
 	}
 

drivers/webdav/driver_test.go

@@ -0,0 +1,89 @@
+package webdav
+
+import (
+	"context"
+	"net/http"
+	"net/http/httptest"
+	"sync/atomic"
+	"testing"
+
+	"github.com/OpenListTeam/OpenList/v4/internal/driver"
+	"github.com/OpenListTeam/OpenList/v4/internal/errs"
+	"github.com/OpenListTeam/OpenList/v4/internal/op"
+)
+
+func TestGetMapsMissingPathToObjectNotFound(t *testing.T) {
+	d, cleanup := newTestDriver(t, nil)
+	defer cleanup()
+
+	_, err := d.Get(context.Background(), "/missing")
+	if !errs.IsObjectNotFound(err) {
+		t.Fatalf("expected object not found, got %v", err)
+	}
+}
+
+func TestMakeDirAfterMissingWebDAVStat(t *testing.T) {
+	var mkcolCount int32
+	d, cleanup := newTestDriver(t, func(w http.ResponseWriter, r *http.Request) bool {
+		if r.Method == "MKCOL" && (r.URL.Path == "/new" || r.URL.Path == "/new/") {
+			atomic.AddInt32(&mkcolCount, 1)
+			w.WriteHeader(http.StatusCreated)
+			return true
+		}
+		return false
+	})
+	defer cleanup()
+
+	if err := op.MakeDir(context.Background(), d, "/new"); err != nil {
+		t.Fatalf("MakeDir failed: %v", err)
+	}
+	if got := atomic.LoadInt32(&mkcolCount); got != 1 {
+		t.Fatalf("expected one MKCOL request, got %d", got)
+	}
+}
+
+func newTestDriver(t *testing.T, extra func(http.ResponseWriter, *http.Request) bool) (*WebDav, func()) {
+	t.Helper()
+
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		if extra != nil && extra(w, r) {
+			return
+		}
+		switch r.Method {
+		case "PROPFIND":
+			if r.URL.Path == "/" {
+				w.Header().Set("Content-Type", "application/xml; charset=utf-8")
+				w.WriteHeader(http.StatusMultiStatus)
+				_, _ = w.Write([]byte(`<?xml version="1.0" encoding="utf-8"?>
+<d:multistatus xmlns:d="DAV:">
+  <d:response>
+    <d:href>/</d:href>
+    <d:propstat>
+      <d:prop>
+        <d:displayname>/</d:displayname>
+        <d:resourcetype><d:collection/></d:resourcetype>
+      </d:prop>
+      <d:status>HTTP/1.1 200 OK</d:status>
+    </d:propstat>
+  </d:response>
+</d:multistatus>`))
+				return
+			}
+			http.NotFound(w, r)
+		case "MKCOL":
+			w.WriteHeader(http.StatusConflict)
+		default:
+			w.WriteHeader(http.StatusMethodNotAllowed)
+		}
+	}))
+
+	d := &WebDav{Addition: Addition{Address: srv.URL, RootPath: driver.RootPath{RootFolderPath: "/"}}}
+	if err := d.Init(context.Background()); err != nil {
+		srv.Close()
+		t.Fatalf("init driver: %v", err)
+	}
+	return d, func() {
+		_ = d.Drop(context.Background())
+		srv.Close()
+	}
+}