Update vcpkg to fix compile on latest MSVC#3739
Conversation
ZehMatt
left a comment
There was a problem hiding this comment.
We should pin it to windows-2022, this drops VS 2022 support. I'm fine with adding a new cmake preset for 2026 but we shouldn't really cut out 2022.
|
We just bumped to vs2025 on OpenRCT2 as well tbh. No need to drop for dropping's sake, but with GitHub moving on as well... Not sure what the reason for keeping vs2022 around would be? |
Well my reason is that I don't want another VS install on my end, I don't even like the latest one, its full of AI garbage. |
|
Okay i've reverted things so that its just a vcpkg bump so that it compiles on new msvc toolsets. It still generates the older solution file so when github does update the runners we can look at this again and consider our options. |
|
Seems I do after all need to have a dedicated preset for VS2026 as otherwise cmake/vcpkg/vs/msvc get into a bit of a bother working out which compiler toolset to use. I could get around it by specifying a toolset but that isn't great either for testing newer things. I could also get around it by not specifying the generator but that would get annoying for general development as it defaults to Ninja. |
Annoyingly google's breakpad was using some non standard code which is only fixed on the very latest vcpkg release so I've had to update that as well.