Skip to content

Update vcpkg to fix compile on latest MSVC#3739

Open
duncanspumpkin wants to merge 6 commits into
OpenLoco:masterfrom
duncanspumpkin:vs2026
Open

Update vcpkg to fix compile on latest MSVC#3739
duncanspumpkin wants to merge 6 commits into
OpenLoco:masterfrom
duncanspumpkin:vs2026

Conversation

@duncanspumpkin
Copy link
Copy Markdown
Contributor

Annoyingly google's breakpad was using some non standard code which is only fixed on the very latest vcpkg release so I've had to update that as well.

Copy link
Copy Markdown
Contributor

@ZehMatt ZehMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pin it to windows-2022, this drops VS 2022 support. I'm fine with adding a new cmake preset for 2026 but we shouldn't really cut out 2022.

@AaronVanGeffen
Copy link
Copy Markdown
Member

We just bumped to vs2025 on OpenRCT2 as well tbh. No need to drop for dropping's sake, but with GitHub moving on as well... Not sure what the reason for keeping vs2022 around would be?

@ZehMatt
Copy link
Copy Markdown
Contributor

ZehMatt commented May 25, 2026

Not sure what the reason for keeping vs2022 around would be?

Well my reason is that I don't want another VS install on my end, I don't even like the latest one, its full of AI garbage.

@duncanspumpkin
Copy link
Copy Markdown
Contributor Author

Okay i've reverted things so that its just a vcpkg bump so that it compiles on new msvc toolsets. It still generates the older solution file so when github does update the runners we can look at this again and consider our options.

@AaronVanGeffen AaronVanGeffen changed the title Update Windows build to vs2026 Update vcpkg to fix compile on latest MSVC May 25, 2026
@AaronVanGeffen AaronVanGeffen requested a review from ZehMatt May 25, 2026 20:03
@AaronVanGeffen AaronVanGeffen added this to the v26.04+ milestone May 25, 2026
@duncanspumpkin
Copy link
Copy Markdown
Contributor Author

Seems I do after all need to have a dedicated preset for VS2026 as otherwise cmake/vcpkg/vs/msvc get into a bit of a bother working out which compiler toolset to use. I could get around it by specifying a toolset but that isn't great either for testing newer things. I could also get around it by not specifying the generator but that would get annoying for general development as it defaults to Ninja.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants