Skip to content

Commit 88419d4

Browse files
committed
fix(ui): update defaultVisibleRange handling and adjust node colors
1 parent f0a835a commit 88419d4

3 files changed

Lines changed: 12 additions & 5 deletions

File tree

ui-ssr/src/components/feature/feature-card.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,12 @@ export const FeatureCardCompactForEmbed = memo(
155155
feature,
156156
className,
157157
plain = false,
158+
defaultVisibleRange = 20,
158159
}: {
159160
feature: FeatureCompact
160161
className?: string
161162
plain?: boolean
163+
defaultVisibleRange?: number
162164
}) => {
163165
return (
164166
<div
@@ -207,7 +209,7 @@ export const FeatureCardCompactForEmbed = memo(
207209
samplingName="top_activations"
208210
totalLength={feature.samples.length}
209211
initialSamples={feature.samples}
210-
defaultVisibleRange={20}
212+
defaultVisibleRange={defaultVisibleRange}
211213
hideTitle={true}
212214
className="mt-0"
213215
/>

ui-ssr/src/routes/embed.dictionaries.$dictionaryName.features.$featureIndex.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export const Route = createFileRoute(
1515
z
1616
.object({
1717
plain: z.boolean().optional().catch(false),
18+
visibleRange: z.coerce.number().optional(),
1819
})
1920
.parse(search),
2021
component: EmbedFeaturePage,
@@ -43,7 +44,7 @@ export const Route = createFileRoute(
4344

4445
function EmbedFeaturePage() {
4546
const { feature } = Route.useLoaderData()
46-
const { plain } = Route.useSearch()
47+
const { plain, visibleRange } = Route.useSearch()
4748

4849
return (
4950
<div
@@ -53,7 +54,11 @@ function EmbedFeaturePage() {
5354
)}
5455
>
5556
<div className={cn('max-w-3xl mx-auto', plain && 'max-w-none')}>
56-
<FeatureCardCompactForEmbed feature={feature} plain={plain} />
57+
<FeatureCardCompactForEmbed
58+
feature={feature}
59+
plain={plain}
60+
defaultVisibleRange={visibleRange}
61+
/>
5762
</div>
5863
</div>
5964
)

ui-ssr/src/utils/circuit.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ export function getNodeColor(featureType: string): string {
2525
case 'embedding':
2626
return '#69b3a2'
2727
case 'cross layer transcoder':
28-
return '#4ecdc4'
28+
return '#f59f00'
2929
case 'lorsa':
30-
return '#7a4cff'
30+
return '#339af0'
3131
default:
3232
return '#95a5a6'
3333
}

0 commit comments

Comments
 (0)