Skip to content

New tests usm (first 5 from PR 632)#780

Merged
fel-cab merged 10 commits into
masterfrom
new_tests_usm
Nov 3, 2023
Merged

New tests usm (first 5 from PR 632)#780
fel-cab merged 10 commits into
masterfrom
new_tests_usm

Conversation

@spophale

Copy link
Copy Markdown
Collaborator

Tested on Summit with clang 18 and gfortran.

Related to #632

@spophale spophale added new test PR that adds new tests 5.0 Related to spec version 5.0 ready PR is ready for review labels Oct 27, 2023
@spophale spophale self-assigned this Oct 27, 2023
Comment thread tests/5.0/requires/test_requires_unified_shared_memory_allocatable_map.F90 Outdated
Comment thread tests/5.0/requires/test_requires_unified_shared_memory_allocatable_map.F90 Outdated
Comment thread tests/5.0/requires/test_requires_unified_shared_memory_allocatable_map.F90 Outdated
Comment thread tests/5.0/requires/test_requires_unified_shared_memory_allocatable_map.F90 Outdated
Comment thread tests/5.0/requires/test_requires_unified_shared_memory_allocatable_map.F90 Outdated
Comment thread tests/5.0/requires/test_requires_unified_shared_memory_malloc.c
seyonglee and others added 2 commits November 1, 2023 11:04
Co-authored-by: fel-cab <110852406+fel-cab@users.noreply.github.com>
…able.F90

Co-authored-by: fel-cab <110852406+fel-cab@users.noreply.github.com>
@seyonglee

Copy link
Copy Markdown
Collaborator

[Results on Summit]

  • tests/5.0/requires/test_requires_unified_shared_memory_allocatable.F90
    • GCC 13.1.1: Fortran test failed: Program received signal SIGSEGV: Segmentation fault - invalid memory reference.
      0x7fff8c076168 in omp_free
      at /autofs/nccs-svm1_proj/stf010/elwasif/gccbuild/src/gcc/libgomp/config/linux/../../allocator.c:626
    • XL 16.1.1-10: "./ompvv/ompvv.F90", line 111.7: 1515-019 (S) Syntax is incorrect.
    • NVHPC 22.11: Fortran test passed.
  • tests/5.0/requires/test_requires_unified_shared_memory_allocatable_map.F90
    • GCC 13.1.1: Fortran test failed: Program received signal SIGSEGV: Segmentation fault - invalid memory reference.
    • XL 16.1.1-10: "./ompvv/ompvv.F90", line 111.7: 1515-019 (S) Syntax is incorrect.
    • NVHPC 22.11: Fortran test passed after applying Felipe's suggestions.
  • tests/5.0/requires/test_requires_unified_shared_memory_malloc.c
    • GCC 13.1.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test passed.
  • tests/5.0/requires/test_requires_unified_shared_memory_malloc_is_device_ptr.c
    • GCC 13.1.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test failed: Condition anArray[i] != i + 20 failed
  • tests/5.0/requires/test_requires_unified_shared_memory_malloc_map.c
    • GCC 13.1.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test passed.

@spophale

spophale commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator Author

@spophale add NULL tests for all dynamic allocations.

@spophale

spophale commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator Author

@seyonglee , @fel-cab ready for review.

@seyonglee

Copy link
Copy Markdown
Collaborator

[Updated results on Summit]

  • tests/5.0/requires/test_requires_unified_shared_memory_malloc.c
    • GCC 13.2.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test passed.
    • LLVM 17.0.0: C test passed.
  • tests/5.0/requires/test_requires_unified_shared_memory_malloc_is_device_ptr.c
    • GCC 13.2.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test passed.
    • LLVM 17.0.0: C test passed.
  • tests/5.0/requires/test_requires_unified_shared_memory_malloc_map.c
    • GCC 13.2.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test failed: Condition anArray[i] != i + 20 failed
    • LLVM 17.0.0: C test passed.

@fel-cab fel-cab merged commit e13a8db into master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0 Related to spec version 5.0 new test PR that adds new tests ready PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants