Cleanup: contentOrder scope

Sophialovesmorrowind · Sophialovesmorrowind · commit 5727ebd78608 · 2026-05-10T22:30:03.000-06:00
diff --git a/apps/opencs/editor.cpp b/apps/opencs/editor.cpp
@@ -199,15 +199,14 @@ std::pair<Files::PathContainer, std::vector<std::string>> CS::Editor::readConfig
 
     mFileDialog.addFiles(dataDirs);
 
-    QStringList contentOrder;
     if (!variables["content"].empty())
     {
+        QStringList contentOrder;
         for (const auto& c : variables["content"].as<std::vector<std::string>>())
             contentOrder.append(QString::fromStdString(c));
-    }
 
-    if (!contentOrder.isEmpty())
         mFileDialog.setContentList(contentOrder, true);
+    }
 
     return std::make_pair(dataDirs, variables["fallback-archive"].as<std::vector<std::string>>());
 }

Original file line number	Diff line number	Diff line change
`@@ -199,15 +199,14 @@ std::pair<Files::PathContainer, std::vector<std::string>> CS::Editor::readConfig`
`199`	`199`
`200`	`200`	`mFileDialog.addFiles(dataDirs);`
`201`	`201`
`202`		`- QStringList contentOrder;`
`203`	`202`	`if (!variables["content"].empty())`
`204`	`203`	`{`
	`204`	`+ QStringList contentOrder;`
`205`	`205`	`for (const auto& c : variables["content"].as<std::vector<std::string>>())`
`206`	`206`	`contentOrder.append(QString::fromStdString(c));`
`207`		`- }`
`208`	`207`
`209`		`- if (!contentOrder.isEmpty())`
`210`	`208`	`mFileDialog.setContentList(contentOrder, true);`
	`209`	`+ }`
`211`	`210`
`212`	`211`	`return std::make_pair(dataDirs, variables["fallback-archive"].as<std::vector<std::string>>());`
`213`	`212`	`}`