Prohibit unversioned python shebangs

Author: mikhailnov

Makefile

@@ -1,10 +1,11 @@
 NAME = spec-helper
-VERSION = 0.31.46
+VERSION = 0.31.49
 SVNPATH = git@github.com:OpenMandrivaSoftware/spec-helper.git
 
 SCRIPT_FILES =  clean_files clean_perl check_elf_files \
 		lib_symlinks fix_file_permissions fix_mo fix_xdg fix_pkgconfig fix_pamd \
-		remove_info_dir remove_libtool_files remove_rpath relink_symlinks fix_eol
+		remove_info_dir remove_libtool_files remove_rpath relink_symlinks fix_eol \
+		python_shebangs
 BIN_FILES    = rediff_patch spec-cleaner
 MACROS_FILES = spec-helper.macros
 TEST_FILES   = t/*.t

python_shebangs

@@ -0,0 +1,44 @@
+#!/bin/sh
+
+if [ -z "$RPM_BUILD_ROOT" ]; then
+    echo "No build root defined" >&2
+    exit 1
+fi
+
+if [ ! -d "$RPM_BUILD_ROOT" ]; then
+    echo "Invalid build root" >&2
+    exit 1
+fi
+
+set -efu
+# We fork a subshell, so working with a variable is not possible,
+# otherwise we will have to switch to bashisms and require /dev/fd/*
+tmpfile="$(mktemp)"
+trap 'rm -f "$tmpfile"' EXIT
+echo 0 > "$tmpfile"
+
+for dir in /bin /usr/bin /sbin /usr/sbin /usr/libexec
+do
+    if [ ! -d "${RPM_BUILD_ROOT}/${dir}" ]; then
+	continue
+    fi
+    find "${RPM_BUILD_ROOT}/${dir}" -type f -print | \
+    while read -r file
+    do
+    # Prohibit shebangs like:
+    # #!/usr/bin/python
+    # #! /usr/bin/python
+    # #!/usr/bin/env python
+    # #! /usr/bin/env python
+    # Note that a space may be in the end of the shebang line
+	if head -n 1 "$file" | grep -qE '^#!([[:blank:]])*.*(/python|[[:blank:]]python)([[:blank:]])*$' ; then
+	    echo "Unversioned Python shebangs are not allowed. Specify python3 or python2 explicitly in $file"
+	    # Do not fail on the 1st error, print all errors at one time
+	    echo 1 > "$tmpfile"
+	fi
+    done
+done
+
+if [ "$(head -n 1 "$tmpfile")" != 0 ]; then
+    exit 1
+fi

spec-helper.macros.in

@@ -16,6 +16,7 @@
     %{?!dont_fix_eol:			[ -n "$DONT_FIX_EOL" ]		|| %_spec_helper_dir/fix_eol} \
     %{?!dont_check_elf_files:		[ -n "$DONT_CHECK_ELF_FILES" ]	|| %_spec_helper_dir/check_elf_files} \
     %{?!dont_remove_rpath:		[ -n "$DONT_REMOVE_RPATH" ]	|| %_spec_helper_dir/remove_rpath} \
+    %{?!dont_check_python_shebangs:		[ -n "$DONT_CHECK_PYTHON_SHEBANGS" ]	|| %_spec_helper_dir/python_shebangs} \
     %{?!__debug_package:		[ -n "%{?dont_strip:1}%{?!dont_strip:$DONT_STRIP}" ] || export DISABLE_DEBUG=1 && %__debug_install_post} \
 %{nil}