Skip to content

Commit 1e14cc9

Browse files
authored
Merge pull request #5910 from martin-frbg/lapack1298
Fix test failures in ?CHKLQ when NB=1 with M=N (Reference-LAPACK PR 1298)
2 parents 136a714 + 5e51708 commit 1e14cc9

4 files changed

Lines changed: 36 additions & 8 deletions

File tree

lapack-netlib/TESTING/LIN/cchklq.f

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -394,12 +394,19 @@ SUBROUTINE CCHKLQ( DOTYPE, NM, MVAL, NN, NVAL, NNB, NBVAL, NXVAL,
394394
CALL CLACPY( 'Full', M, N, A, LDA, AF, LDA )
395395
*
396396
SRNAMT = 'CGELS'
397-
CALL CGELS( 'No transpose', M, N, NRHS, AF,
397+
CALL CGELS( 'No transpose', M, N, NRHS, AF,
398398
$ LDA, X, LDA, WORK, LWORK, INFO )
399399
*
400+
* Re-factorize AF with CGELQF for subsequent
401+
* LQ tests which expect LQ factorization in AF.
402+
*
403+
CALL CLACPY( 'Full', M, N, A, LDA, AF, LDA )
404+
CALL CGELQF( M, N, AF, LDA, TAU, WORK,
405+
$ LWORK, INFO )
406+
*
400407
* Check error code from CGELS.
401408
*
402-
IF( INFO.NE.0 )
409+
IF( INFO.NE.0 )
403410
$ CALL ALAERH( PATH, 'CGELS', INFO, 0, 'N',
404411
$ M, N, NRHS, -1, NB, IMAT,
405412
$ NFAIL, NERRS, NOUT )

lapack-netlib/TESTING/LIN/dchklq.f

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,12 +397,19 @@ SUBROUTINE DCHKLQ( DOTYPE, NM, MVAL, NN, NVAL, NNB, NBVAL, NXVAL,
397397
CALL DLACPY( 'Full', M, N, A, LDA, AF, LDA )
398398
*
399399
SRNAMT = 'DGELS'
400-
CALL DGELS( 'No transpose', M, N, NRHS, AF,
400+
CALL DGELS( 'No transpose', M, N, NRHS, AF,
401401
$ LDA, X, LDA, WORK, LWORK, INFO )
402402
*
403+
* Re-factorize AF with DGELQF for subsequent
404+
* LQ tests which expect LQ factorization in AF.
405+
*
406+
CALL DLACPY( 'Full', M, N, A, LDA, AF, LDA )
407+
CALL DGELQF( M, N, AF, LDA, TAU, WORK,
408+
$ LWORK, INFO )
409+
*
403410
* Check error code from DGELS.
404411
*
405-
IF( INFO.NE.0 )
412+
IF( INFO.NE.0 )
406413
$ CALL ALAERH( PATH, 'DGELS', INFO, 0, 'N',
407414
$ M, N, NRHS, -1, NB, IMAT,
408415
$ NFAIL, NERRS, NOUT )

lapack-netlib/TESTING/LIN/schklq.f

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -394,12 +394,19 @@ SUBROUTINE SCHKLQ( DOTYPE, NM, MVAL, NN, NVAL, NNB, NBVAL, NXVAL,
394394
CALL SLACPY( 'Full', M, N, A, LDA, AF, LDA )
395395
*
396396
SRNAMT = 'SGELS'
397-
CALL SGELS( 'No transpose', M, N, NRHS, AF,
397+
CALL SGELS( 'No transpose', M, N, NRHS, AF,
398398
$ LDA, X, LDA, WORK, LWORK, INFO )
399399
*
400+
* Re-factorize AF with SGELQF for subsequent
401+
* LQ tests which expect LQ factorization in AF.
402+
*
403+
CALL SLACPY( 'Full', M, N, A, LDA, AF, LDA )
404+
CALL SGELQF( M, N, AF, LDA, TAU, WORK,
405+
$ LWORK, INFO )
406+
*
400407
* Check error code from SGELS.
401408
*
402-
IF( INFO.NE.0 )
409+
IF( INFO.NE.0 )
403410
$ CALL ALAERH( PATH, 'SGELS', INFO, 0, 'N',
404411
$ M, N, NRHS, -1, NB, IMAT,
405412
$ NFAIL, NERRS, NOUT )

lapack-netlib/TESTING/LIN/zchklq.f

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -394,12 +394,19 @@ SUBROUTINE ZCHKLQ( DOTYPE, NM, MVAL, NN, NVAL, NNB, NBVAL, NXVAL,
394394
CALL ZLACPY( 'Full', M, N, A, LDA, AF, LDA )
395395
*
396396
SRNAMT = 'ZGELS'
397-
CALL ZGELS( 'No transpose', M, N, NRHS, AF,
397+
CALL ZGELS( 'No transpose', M, N, NRHS, AF,
398398
$ LDA, X, LDA, WORK, LWORK, INFO )
399399
*
400+
* Re-factorize AF with ZGELQF for subsequent
401+
* LQ tests which expect LQ factorization in AF.
402+
*
403+
CALL ZLACPY( 'Full', M, N, A, LDA, AF, LDA )
404+
CALL ZGELQF( M, N, AF, LDA, TAU, WORK,
405+
$ LWORK, INFO )
406+
*
400407
* Check error code from ZGELS.
401408
*
402-
IF( INFO.NE.0 )
409+
IF( INFO.NE.0 )
403410
$ CALL ALAERH( PATH, 'ZGELS', INFO, 0, 'N',
404411
$ M, N, NRHS, -1, NB, IMAT,
405412
$ NFAIL, NERRS, NOUT )

0 commit comments

Comments
 (0)