Skip to content

Fix unwanted "hard" fallback to Prescott in runtime detection of Intel cpus #4268

Merged
martin-frbg merged 1 commit into
OpenMathLib:developfrom
martin-frbg:issue4267
Oct 18, 2023
Merged

Fix unwanted "hard" fallback to Prescott in runtime detection of Intel cpus #4268
martin-frbg merged 1 commit into
OpenMathLib:developfrom
martin-frbg:issue4267

Conversation

@martin-frbg

Copy link
Copy Markdown
Collaborator

fixes #4267

@martin-frbg martin-frbg added this to the 0.3.25 milestone Oct 18, 2023
@ogrisel

ogrisel commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

@jeromedockes can you please rebuild this branch of OpenBLAS on your host with DYNAMIC_ARCH enabled and check that the right architecture is detected (e.g. with threadpoolctl)?

@martin-frbg
martin-frbg merged commit 5c411ac into OpenMathLib:develop Oct 18, 2023
@jeromedockes

jeromedockes commented Oct 18, 2023

Copy link
Copy Markdown

@ogrisel sorry for the delay. yes I confirm that the right architecture is detected now. I compiled this

#include <cblas.h>
#include <stdio.h>

void main() { printf("architecture: %s\n", openblas_get_corename()); }

with the develop branch of OpenBLAS (before this PR was merged) I get

architecture: Prescott

and with this branch I get

architecture: Haswell

(and in any case if I compile OpenBLAS without DYNAMIC_ARCH enabled I get architecture: HASWELL

@ogrisel

ogrisel commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Thanks very much for the confirmation !

@ogrisel

ogrisel commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

And thanks @martin-frbg for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

detected architecture is Prescott on a recent CPU

3 participants