Add dynamic dispatch to AIX and clang for Power#4280
Merged
martin-frbg merged 28 commits intoNov 2, 2023
Conversation
added 26 commits
September 29, 2023 08:08
martin-frbg
reviewed
Nov 1, 2023
| #define CPU_UNKNOWN 0 | ||
| #define CPU_POWER5 5 | ||
| #define CPU_POWER6 6 | ||
| #define CPU_POWER7 7 |
Collaborator
There was a problem hiding this comment.
POWER7 currently does not exist as an actual, unique target - it is an alias for POWER6. Do you plan to change that ?
martin-frbg
reviewed
Nov 1, 2023
martin-frbg
left a comment
martin-frbg
left a comment
Collaborator
There was a problem hiding this comment.
thanks - I guess arch==power7 would still be valid and return CPU_POWER6 though?
Contributor
Author
|
Fixed. We would like these changes in the next release (Nov 5th) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known issue (to be done as a separate PR): compiling with gcc/xlf in AIX.
Works with Linux - gcc & clang, AIX - gcc/gfortran, xlc/xlf.
This adds dynamic dispatch to AIX. It also adds dynamic dispatch for clang/LLVM for Linux. All for PowerPC