Skip to content

Fix allocations and compiler warnings in ZROTG #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 4 commits into from
Nov 5, 2023
Merged

Fix allocations and compiler warnings in ZROTG #4289

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f59eb5f
Clean up ZROTG
martin-frbg Nov 5, 2023
67269c4
Clean up ZROTG
martin-frbg Nov 5, 2023
fbe27a3
Update zrotg.c
martin-frbg Nov 5, 2023
fb2ca21
Update zrotg.c
martin-frbg Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions interface/zrotg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,12 @@ void CNAME(void *VDA, void *VDB, FLOAT *C, void *VS) {
FLOAT db_r = *(DB+0);
FLOAT db_i = *(DB+1);
//long double r;
FLOAT *r, *S1=(FLOAT *)malloc(2*sizeof(FLOAT));
FLOAT *R=(FLOAT *)malloc(2*sizeof(FLOAT));
FLOAT S1[2];
FLOAT R[2];
long double d;

FLOAT ada = da_r * da_r + da_i * da_i;
FLOAT adb = db_r * db_r + db_i * db_i;
FLOAT adart = sqrt( da_r * da_r + da_i * da_i);
FLOAT adbrt = sqrt( db_r * db_r + db_i * db_i);

PRINT_DEBUG_NAME;

Expand Down Expand Up @@ -115,10 +113,13 @@ void CNAME(void *VDA, void *VDB, FLOAT *C, void *VS) {
}
} else {
*C = ada / adahsq;
if (*C >= safmin)
if (*C >= safmin) {
*R = *DA / *C;
else
*(R+1) = *(DA+1) / *(C+1);
} else {
*R = *DA * (h / adahsq);
*(R+1) = *(DA+1) * (h / adahsq);
}
*S = *S1 * ada / adahsq;
*(S+1) = *(S1+1) * ada / adahsq;
}
Expand Down Expand Up @@ -178,4 +179,4 @@ void CNAME(void *VDA, void *VDB, FLOAT *C, void *VS) {
}
}
}