Optimize gemv_n_sve kernel#5157
Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom Mar 12, 2025
Merged
Conversation
fadara01
reviewed
Mar 3, 2025
Contributor
|
Can we also update the plot s.t:
|
fadara01
reviewed
Mar 3, 2025
Collaborator
|
yes, an explanation of the benchmark graph would be nice - I'm not sure I understand why your PR would result in two very narrow regions where there is more than tenfold speedup ? |
Contributor
Author
Please refer to the updated graph. For the regions where we see spikes, The baseline performance of these problem sizes are poor and that's why we see spike in speedup. |
Contributor
Author
Please see the updated graph. |
Contributor
|
@martin-frbg could you please re-review? |
fadara01
reviewed
Mar 10, 2025
fadara01
reviewed
Mar 10, 2025
Collaborator
|
Looks good to me, thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loop-unrolling of sgemv_n kernel is implemented with svmla_lane, along with a main loop and a tail loop.
The graph below shows performance improvement for OMP_NUM_THREADS=1 on Graviton-3: