replace customize bf16_to_fp32 with arm neon vcvtah_f32_bf16#5181
Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom Mar 13, 2025
Merged
replace customize bf16_to_fp32 with arm neon vcvtah_f32_bf16#5181martin-frbg merged 1 commit intoOpenMathLib:developfrom
martin-frbg merged 1 commit intoOpenMathLib:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is to replace hack func to cast bf16 to fp32 with standard arm neon intrinsics in arm64 sbgemv_n kernel in previous pr: #5160.
This PR may also slightly improve performance by reducing a cast from two to one assembly instruction—specifically, replacing (UMOV, UBFIZ) with SHL